Unverified Commit b0ec2038 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #55119 from pires/fix_e2e_scheduling_predicates_hostname

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix scheduler predicates test that may violate DNS label rules **What this PR does / why we need it**: This commit fixes an issue where in clusters which have FQDN as the node names, one of the scheduling predicates tests will fail because it will try and run a pod with a name that violates DNS-1123 rules. As an example, one such pod name could look like "filler-pod-kube-node-0.kubelet.mesos". **Which issue(s) this PR fixes**: Fixes #55117 **Special notes for your reviewer**: As soon as this is approved, I will create the cherry-pick PRs for 1.7.x. It doesn't apply on 1.8.x. cc @aveshagarwal @kubernetes/sig-scheduling-pr-reviews **Release note**: ``` NONE ```
parents 21062657 d2edb8af
......@@ -291,7 +291,7 @@ var _ = SIGDescribe("SchedulerPredicates [Serial]", func() {
for nodeName, cpu := range nodeToAllocatableMap {
requestedCPU := cpu * 7 / 10
fillerPods = append(fillerPods, createPausePod(f, pausePodConfig{
Name: "filler-pod-" + nodeName,
Name: "filler-pod-" + string(uuid.NewUUID()),
Resources: &v1.ResourceRequirements{
Limits: v1.ResourceList{
v1.ResourceCPU: *resource.NewMilliQuantity(requestedCPU, "DecimalSI"),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment