Skip to content

K
k3s
Commit b0d2f68c authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #42294 from mlmhl/deploy-controller-cachesync

Automatic merge from submit-queue fix rsListerSynced and podListerSynced for DeploymentController **What this PR does / why we need it**: There is a mistake when initializing `DeploymentController`'s `rsListerSynced` and `podListerSynced` in `NewDeploymentController`, they are all initialized to `Deployment`'s `Informer`, so the `DeploymentController` maybe running before the `ReplicaSet` cache and `Pod` cache has been synced. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: Indeed according unit test is neccessary, but this bug fix is simple, and if the tests is neccessary I will submit another PR later. **Release note**: ```release-note ```
parents 3bc342cf 5440752e
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 2 deletions
pkg/controller/deployment/deployment_controller.go
View file @ b0d2f68c
......@@ -138,8 +138,8 @@ func NewDeploymentController(dInformer extensionsinformers.DeploymentInformer, r
dc.rsLister = rsInformer.Lister()
dc.podLister = podInformer.Lister()
dc.dListerSynced = dInformer.Informer().HasSynced
dc.rsListerSynced = dInformer.Informer().HasSynced
dc.podListerSynced = dInformer.Informer().HasSynced
dc.rsListerSynced = rsInformer.Informer().HasSynced
dc.podListerSynced = podInformer.Informer().HasSynced
return dc
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment