Merge pull request #59218 from ravisantoshgudimetla/flake-59150

Automatic merge from submit-queue (batch tested with PRs 60342, 60505, 59218, 52900, 60486). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Increase failureThresholds for failing HTTP liveness test **What this PR does / why we need it**: Removes test from e2e which relies on HTTP liveness as a measure to tell if the container is good or bad. While this is not a bad idea, we cannot rely on this test as HTTP liveness relies on network/infrastructure etc on which sometimes we have no control over. While increasing the timeout may be an option it may not be ideal for all cloud providers/type of hardware etc. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #59150 **Special notes for your reviewer**: I have stated reasons in the issue #59150. We have seen that this test is flaking recently in https://github.com/openshift/origin/issues/12072 **Release note**: ```release-note NONE ```

Merge pull request #59218 from ravisantoshgudimetla/flake-59150
b0c988ca · Kubernetes Submit Queue · GitHub · 47b1d72d · ce2c4686 · b0c988ca
Unverified Commit b0c988ca authored Feb 28, 2018 by Kubernetes Submit Queue Committed by GitHub Feb 28, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

container_probe.go test/e2e/common/container_probe.go +1 -1

No files found.
--- a/test/e2e/common/container_probe.go
+++ b/test/e2e/common/container_probe.go
@@ -263,7 +263,7 @@ var _ = framework.KubeDescribe("Probing container", func() {
 							},
 							InitialDelaySeconds: 15,
 							TimeoutSeconds:      5,
-							FailureThreshold:    1,
+							FailureThreshold:    5, // to accommodate nodes which are slow in bringing up containers.
 						},
 					},
 				},