Merge pull request #52344 from smarterclayton/no_log_pull

Automatic merge from submit-queue (batch tested with PRs 48226, 52046, 52231, 52344, 52352) Log at higher verbosity levels some common SyncPod errors This log message was 90% of all glog.Errorf level statements reported on a production cluster, hiding other more impactful errors. We already log it in start container, but for extra caution we continue to log it at v(3) here (the downside of not logging a start container error is worse than some log spam at higher levels). HandleError() is intended only for unknown and unexpected errors. ```release-note NONE ``` @derekwaynecarr @sjenning

Merge pull request #52344 from smarterclayton/no_log_pull
b04f81d3 · Kubernetes Submit Queue · GitHub · 434fffb6 · a5ac80cb · b04f81d3
Commit b04f81d3 authored Sep 12, 2017 by Kubernetes Submit Queue Committed by GitHub Sep 12, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 1 deletion

kuberuntime_manager.go pkg/kubelet/kuberuntime/kuberuntime_manager.go +8 -1

No files found.
--- a/pkg/kubelet/kuberuntime/kuberuntime_manager.go
+++ b/pkg/kubelet/kuberuntime/kuberuntime_manager.go
@@ -688,7 +688,14 @@ func (m *kubeGenericRuntimeManager) SyncPod(pod *v1.Pod, _ v1.PodStatus, podStat
 		glog.V(4).Infof("Creating container %+v in pod %v", container, format.Pod(pod))
 		if msg, err := m.startContainer(podSandboxID, podSandboxConfig, container, pod, podStatus, pullSecrets, podIP); err != nil {
 			startContainerResult.Fail(err, msg)
-			utilruntime.HandleError(fmt.Errorf("container start failed: %v: %s", err, msg))
+			// known errors that are logged in other places are logged at higher levels here to avoid
+			// repetitive log spam
+			switch {
+			case err == images.ErrImagePullBackOff:
+				glog.V(3).Infof("container start failed: %v: %s", err, msg)
+			default:
+				utilruntime.HandleError(fmt.Errorf("container start failed: %v: %s", err, msg))
+			}
 			continue
 		}
 	}