Merge pull request #53841 from crimsonfaith91/deployment-upgrade

Automatic merge from submit-queue (batch tested with PRs 52794, 54243, 54248, 53491, 53841). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. revamp deployment upgrade test **What this PR does / why we need it**: This PR revamps existing deployment upgrade test, removing redundant steps that is covered by replicaset upgrade test. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: xref #52113 **Special notes for your reviewer**: The replicaset upgrade test PR is here: #52449 **Release note**: ```release-note NONE ```

Merge pull request #53841 from crimsonfaith91/deployment-upgrade
adb7aed2 · Kubernetes Submit Queue · GitHub · d98911c5 · dd3b7820 · adb7aed2
Commit adb7aed2 authored Oct 19, 2017 by Kubernetes Submit Queue Committed by GitHub Oct 19, 2017
Showing with 42 additions and 0 deletions

deployment_util.go test/e2e/framework/deployment_util.go +19 -0

deployments.go test/e2e/upgrades/apps/deployments.go +0 -0

deployment.go test/utils/deployment.go +23 -0

No files found.
--- a/test/e2e/framework/deployment_util.go
+++ b/test/e2e/framework/deployment_util.go
@@ -289,3 +289,22 @@ func RunDeployment(config testutils.DeploymentConfig) error {
 func logPodsOfDeployment(c clientset.Interface, deployment *extensions.Deployment, rsList []*extensions.ReplicaSet) {
 	testutils.LogPodsOfDeployment(c, deployment, rsList, Logf)
 }
+
+func WaitForDeploymentCompletes(c clientset.Interface, deployment *extensions.Deployment) error {
+	return testutils.WaitForDeploymentCompletes(c, deployment, Logf, Poll, pollLongTimeout)
+}
+
+func WaitForDeploymentRevision(c clientset.Interface, d *extensions.Deployment, targetRevision string) error {
+	err := wait.PollImmediate(Poll, pollLongTimeout, func() (bool, error) {
+		deployment, err := c.ExtensionsV1beta1().Deployments(d.Namespace).Get(d.Name, metav1.GetOptions{})
+		if err != nil {
+			return false, err
+		}
+		revision := deployment.Annotations[deploymentutil.RevisionAnnotation]
+		return revision == targetRevision, nil
+	})
+	if err != nil {
+		return fmt.Errorf("error waiting for revision to become %q for deployment %q: %v", targetRevision, d.Name, err)
+	}
+	return nil
+}
--- a/test/e2e/upgrades/apps/deployments.go
+++ b/test/e2e/upgrades/apps/deployments.go
--- a/test/utils/deployment.go
+++ b/test/utils/deployment.go
@@ -244,3 +244,26 @@ func WaitForObservedDeployment(c clientset.Interface, ns, deploymentName string,
 		return c.Extensions().Deployments(ns).Get(deploymentName, metav1.GetOptions{})
 	}, desiredGeneration, 2*time.Second, 1*time.Minute)
 }
+
+// Pool until deployment status and its underlying resources reach the desired state.
+func WaitForDeploymentCompletes(c clientset.Interface, d *extensions.Deployment, logf LogfFn, pollInterval, pollTimeout time.Duration) error {
+	var reason string
+	err := wait.PollImmediate(pollInterval, pollTimeout, func() (bool, error) {
+		deployment, err := c.ExtensionsV1beta1().Deployments(d.Namespace).Get(d.Name, metav1.GetOptions{})
+		if err != nil {
+			return false, err
+		}
+		// When the deployment status and its underlying resources reach the desired state, we're done
+		if deploymentutil.DeploymentComplete(d, &deployment.Status) {
+			return true, nil
+		}
+		reason = fmt.Sprintf("deployment status: %#v", deployment.Status)
+		logf(reason)
+		return false, nil
+	})
+
+	if err == wait.ErrWaitTimeout {
+		err = fmt.Errorf("timeout waiting for deployment to complete: %v, most recent deployment status: %s", err, reason)
+	}
+	return err
+}