Merge pull request #44939 from sjenning/adjust-logging

Automatic merge from submit-queue don't HandleError on container start failure Failing to start containers is a common error case if there is something wrong with the container image or environment like missing mounts/configs/permissions/etc. Not only is it common; it is reoccurring as backoff happens and new attempts to start the container are made. `HandleError` it too verbose for this very common situation. Replace `HandleError` with `glog.V(3).Infof` xref https://github.com/openshift/origin/issues/13889 @smarterclayton @derekwaynecarr @eparis

Merge pull request #44939 from sjenning/adjust-logging
acca01bc · Kubernetes Submit Queue · GitHub · b2d714a7 · ffb9f5aa · acca01bc
Commit acca01bc authored Apr 27, 2017 by Kubernetes Submit Queue Committed by GitHub Apr 27, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

docker_manager.go pkg/kubelet/dockertools/docker_manager.go +2 -2

No files found.
--- a/pkg/kubelet/dockertools/docker_manager.go
+++ b/pkg/kubelet/dockertools/docker_manager.go
@@ -2371,7 +2371,7 @@ func (dm *DockerManager) SyncPod(pod *v1.Pod, _ v1.PodStatus, podStatus *kubecon
 		glog.V(4).Infof("Creating init container %+v in pod %v", container, format.Pod(pod))
 		if err, msg := dm.tryContainerStart(container, pod, podStatus, pullSecrets, namespaceMode, pidMode, podIP); err != nil {
 			startContainerResult.Fail(err, msg)
-			utilruntime.HandleError(fmt.Errorf("container start failed: %v: %s", err, msg))
+			glog.V(3).Infof("container start failed: %v: %s", err, msg)
 			return
 		}
@@ -2409,7 +2409,7 @@ func (dm *DockerManager) SyncPod(pod *v1.Pod, _ v1.PodStatus, podStatus *kubecon
 		glog.V(4).Infof("Creating container %+v in pod %v", container, format.Pod(pod))
 		if err, msg := dm.tryContainerStart(container, pod, podStatus, pullSecrets, namespaceMode, pidMode, podIP); err != nil {
 			startContainerResult.Fail(err, msg)
-			utilruntime.HandleError(fmt.Errorf("container start failed: %v: %s", err, msg))
+			glog.V(3).Infof("container start failed: %v: %s", err, msg)
 			continue
 		}
 	}