A load balancer should be updated if a service's UID has changed.

The load balancer's name is determined by the service's UID. If the service's UID has changed (presumably due to a delete and recreate), then we need to recreate the load balancer as well to avoid eventually leaking the old one.

A load balancer should be updated if a service's UID has changed.
ab797d1b · Alex Robinson · 4ce5f68e · ab797d1b
Commit ab797d1b authored Feb 26, 2016 by Alex Robinson
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

servicecontroller.go pkg/controller/service/servicecontroller.go +5 -0

No files found.
--- a/pkg/controller/service/servicecontroller.go
+++ b/pkg/controller/service/servicecontroller.go
@@ -498,6 +498,11 @@ func (s *ServiceController) needsUpdate(oldService *api.Service, newService *api
 	if !reflect.DeepEqual(oldService.Annotations, newService.Annotations) {
 		return true
 	}
+	if oldService.UID != newService.UID {
+		s.eventRecorder.Eventf(newService, api.EventTypeNormal, "UID", "%v -> %v",
+			oldService.UID, newService.UID)
+		return true
+	}
 	return false
 }