Merge pull request #46017 from xilabao/fix-print-of-generic-resources

Automatic merge from submit-queue (batch tested with PRs 44412, 44810, 47130, 46017, 47829) fix self link error of generic resources in describe command **What this PR does / why we need it**: fix Self Link error ``` ./cluster/kubectl.sh describe clusterrole system:controller:ttl-controller Name: system:controller:ttl-controller Namespace: Labels: kubernetes.io/bootstrapping=rbac-defaults Annotations: rbac.authorization.kubernetes.io/autoupdate=true API Version: rbac.authorization.k8s.io/v1alpha1 Kind: ClusterRole Metadata: Creation Timestamp: 2017-05-18T06:42:02Z Resource Version: 80 Self Link: /apis/rbac.authorization.k8s.io/v1alpha1/clusterroles/system%!A(MISSING)controller%!A(MISSING)ttl-controller UID: 19a705a4-3b95-11e7-9d55-7427ea6f0fe3 Rules: API Groups: Resources: nodes Verbs: list patch update watch API Groups: Resources: events Verbs: create patch update Events: <none> ``` **Which issue this PR fixes**: fixes #48743 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```

Merge pull request #46017 from xilabao/fix-print-of-generic-resources
a9aabd76 · Kubernetes Submit Queue · GitHub · 6c1552c5 · fa563dce · a9aabd76
Commit a9aabd76 authored Jul 11, 2017 by Kubernetes Submit Queue Committed by GitHub Jul 11, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 4 deletions

describe.go pkg/printers/internalversion/describe.go +4 -4

No files found.
--- a/pkg/printers/internalversion/describe.go
+++ b/pkg/printers/internalversion/describe.go
@@ -231,7 +231,7 @@ func printUnstructuredContent(w PrefixWriter, level int, content map[string]inte
 			if slice.ContainsString(skip, skipExpr, nil) {
 				continue
 			}
-			w.Write(level, fmt.Sprintf("%s:\n", smartLabelFor(field)))
+			w.Write(level, "%s:\n", smartLabelFor(field))
 			printUnstructuredContent(w, level+1, typedValue, skipExpr, skip...)
 		case []interface{}:
@@ -239,13 +239,13 @@ func printUnstructuredContent(w PrefixWriter, level int, content map[string]inte
 			if slice.ContainsString(skip, skipExpr, nil) {
 				continue
 			}
-			w.Write(level, fmt.Sprintf("%s:\n", smartLabelFor(field)))
+			w.Write(level, "%s:\n", smartLabelFor(field))
 			for _, child := range typedValue {
 				switch typedChild := child.(type) {
 				case map[string]interface{}:
 					printUnstructuredContent(w, level+1, typedChild, skipExpr, skip...)
 				default:
-					w.Write(level+1, fmt.Sprintf("%v\n", typedChild))
+					w.Write(level+1, "%v\n", typedChild)
 				}
 			}
@@ -254,7 +254,7 @@ func printUnstructuredContent(w PrefixWriter, level int, content map[string]inte
 			if slice.ContainsString(skip, skipExpr, nil) {
 				continue
 			}
-			w.Write(level, fmt.Sprintf("%s:\t%v\n", smartLabelFor(field), typedValue))
+			w.Write(level, "%s:\t%v\n", smartLabelFor(field), typedValue)
 		}
 	}
 }