Unverified Commit a8787dac authored by Kubernetes Prow Robot's avatar Kubernetes Prow Robot Committed by GitHub

Merge pull request #76927 from mrkm4ntr/unnecessary-goroutine

Do not generate unnecessary goroutines
parents e1d40da0 f8e81337
......@@ -646,7 +646,7 @@ func (s *ProxyServer) Run() error {
// This has to start after the calls to NewServiceConfig and NewEndpointsConfig because those
// functions must configure their shared informer event handlers first.
go informerFactory.Start(wait.NeverStop)
informerFactory.Start(wait.NeverStop)
// Birth Cry after the birth is successful
s.birthCry()
......
......@@ -127,7 +127,7 @@ func setupQuotaController(t *testing.T, kubeClient kubernetes.Interface, lister
t.Fatal(err)
}
stop := make(chan struct{})
go informerFactory.Start(stop)
informerFactory.Start(stop)
return quotaController{qc, stop}
}
......
......@@ -1445,7 +1445,7 @@ func newTestWatchPlugin(t *testing.T, fakeClient *fakeclient.Clientset) (*csiPlu
factory := informers.NewSharedInformerFactory(fakeClient, csiResyncPeriod)
csiDriverInformer := factory.Storage().V1beta1().CSIDrivers()
csiDriverLister := csiDriverInformer.Lister()
go factory.Start(wait.NeverStop)
factory.Start(wait.NeverStop)
host := volumetest.NewFakeVolumeHostWithCSINodeName(
tmpDir,
......
......@@ -122,7 +122,7 @@ func TestCSI_VolumeAll(t *testing.T) {
fakeWatcher := watch.NewRaceFreeFake()
factory := informers.NewSharedInformerFactory(client, csiResyncPeriod)
go factory.Start(wait.NeverStop)
factory.Start(wait.NeverStop)
host := volumetest.NewFakeVolumeHostWithCSINodeName(
tmpDir,
......
......@@ -1034,7 +1034,7 @@ func (pm *VolumePluginMgr) Run(stopCh <-chan struct{}) {
// start informer for CSIDriver
if utilfeature.DefaultFeatureGate.Enabled(features.CSIDriverRegistry) {
informerFactory := kletHost.GetInformerFactory()
go informerFactory.Start(stopCh)
informerFactory.Start(stopCh)
}
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment