Adds a command-line flag '--disable-helm-controller' that will disable

the server's built-in helm controller. Problem: Testing installation and uninstallation of the Helm Controller on k3s is not possible if the Helm Controller is baked into the k3s server. Solution: The Helm Controller can optionally be disabled, which will allow users to manage its installation manually. Signed-off-by: Joe Kralicky <joe.kralicky@suse.com>

Adds a command-line flag '--disable-helm-controller' that will disable
a84c75af · Joe Kralicky · cf557127 · a84c75af · a84c75af · a84c75af
Commit a84c75af authored Jun 25, 2021 by Joe Kralicky
Hide whitespace changes
Inline Side-by-side

Showing with 19 additions and 8 deletions

server.go pkg/cli/cmds/server.go +6 -0

server.go pkg/cli/server/server.go +1 -0

types.go pkg/daemons/config/types.go +1 -0

server.go pkg/server/server.go +11 -8

No files found.
--- a/pkg/cli/cmds/server.go
+++ b/pkg/cli/cmds/server.go
@@ -53,6 +53,7 @@ type Server struct {
 	DefaultLocalStoragePath  string
 	DisableCCM               bool
 	DisableNPC               bool
+	DisableHelmController    bool
 	DisableKubeProxy         bool
 	DisableAPIServer         bool
 	DisableControllerManager bool
@@ -340,6 +341,11 @@ func NewServerCommand(action func(*cli.Context) error) cli.Command {
 				Destination: &ServerConfig.DisableNPC,
 			},
 			cli.BoolFlag{
+				Name:        "disable-helm-controller",
+				Usage:       "(components) Disable Helm controller",
+				Destination: &ServerConfig.DisableHelmController,
+			},
+			cli.BoolFlag{
 				Name:        "disable-apiserver",
 				Hidden:      true,
 				Usage:       "(experimental/components) Disable running api server",

--- a/pkg/cli/server/server.go
+++ b/pkg/cli/server/server.go
@@ -119,6 +119,7 @@ func run(app *cli.Context, cfg *cmds.Server, leaderControllers server.CustomCont
 	serverConfig.ControlConfig.ExtraCloudControllerArgs = cfg.ExtraCloudControllerArgs
 	serverConfig.ControlConfig.DisableCCM = cfg.DisableCCM
 	serverConfig.ControlConfig.DisableNPC = cfg.DisableNPC
+	serverConfig.ControlConfig.DisableHelmController = cfg.DisableHelmController
 	serverConfig.ControlConfig.DisableKubeProxy = cfg.DisableKubeProxy
 	serverConfig.ControlConfig.DisableETCD = cfg.DisableETCD
 	serverConfig.ControlConfig.DisableAPIServer = cfg.DisableAPIServer

--- a/pkg/daemons/config/types.go
+++ b/pkg/daemons/config/types.go
@@ -140,6 +140,7 @@ type Control struct {
 	SystemDefaultRegistry    string
 	DisableCCM               bool
 	DisableNPC               bool
+	DisableHelmController    bool
 	DisableKubeProxy         bool
 	DisableAPIServer         bool
 	DisableControllerManager bool

--- a/pkg/server/server.go
+++ b/pkg/server/server.go
@@ -186,14 +186,17 @@ func coreControllers(ctx context.Context, sc *Context, config *Config) error {
 		servicelb.DefaultLBImage = config.ControlConfig.SystemDefaultRegistry + "/" + servicelb.DefaultLBImage
 	}
-	helm.Register(ctx,
+	if !config.ControlConfig.DisableHelmController {
-		sc.Apply,
+		helm.Register(ctx,
-		sc.Helm.Helm().V1().HelmChart(),
+			sc.Apply,
-		sc.Helm.Helm().V1().HelmChartConfig(),
+			sc.Helm.Helm().V1().HelmChart(),
-		sc.Batch.Batch().V1().Job(),
+			sc.Helm.Helm().V1().HelmChartConfig(),
-		sc.Auth.Rbac().V1().ClusterRoleBinding(),
+			sc.Batch.Batch().V1().Job(),
-		sc.Core.Core().V1().ServiceAccount(),
+			sc.Auth.Rbac().V1().ClusterRoleBinding(),
-		sc.Core.Core().V1().ConfigMap())
+			sc.Core.Core().V1().ServiceAccount(),
+			sc.Core.Core().V1().ConfigMap())
+	}
 	if err := servicelb.Register(ctx,
 		sc.K8s,
 		sc.Apply,