Merge pull request #40120 from ixdy/bazel-release-tars

Automatic merge from submit-queue bazel: add a config setting to control embedding kubernetes-src.tar.gz **What this PR does / why we need it**: currently a change anywhere in the tree will cause `kubernetes-src.tar.gz` to need to be regenerated, and thus also the server and node tarballs. All of these operations are slow, so for the sake of developer productivity, only include `kubernetes-src.tar.gz` when we need it (e.g. if we were doing a real release). I don't have metrics on how much of an effect this has, but I expect it should help incremental builds, especially those that don't affect any node/server targets. To embed the srcs tarball with this change, you'd run ```console bazel build //build/release-tars --define EMBED_LICENSE_TARGETS=true ``` **Release note**: ```release-note NONE ```

Merge pull request #40120 from ixdy/bazel-release-tars
a374d277 · Kubernetes Submit Queue · GitHub · 88257cfb · 16aa59c3 · a374d277
Commit a374d277 authored Jan 20, 2017 by Kubernetes Submit Queue Committed by GitHub Jan 20, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 21 additions and 4 deletions

BUILD build/release-tars/BUILD +21 -4

No files found.
--- a/build/release-tars/BUILD
+++ b/build/release-tars/BUILD
@@ -15,6 +15,14 @@ filegroup(
    tags = ["automanaged"],
 )
+config_setting(
+    name = "embed_license_targets",
+    values = {
+        "define": "EMBED_LICENSE_TARGETS=true",
+    },
+    visibility = ["//visibility:private"],
+)
 pkg_tar(
    name = "kubernetes-src",
    extension = "tar.gz",
@@ -116,7 +124,10 @@ pkg_tar(
 pkg_tar(
    name = "kubernetes-node-%s" % PLATFORM_ARCH_STRING,
    extension = "tar.gz",
-    files = LICENSE_TARGETS,
+    files = select({
+        ":embed_license_targets": LICENSE_TARGETS,
+        "//conditions:default": [],
+    }),
    mode = "0644",
    package_dir = "kubernetes",
    deps = [
@@ -153,7 +164,10 @@ pkg_tar(
 pkg_tar(
    name = "kubernetes-server-%s" % PLATFORM_ARCH_STRING,
    extension = "tar.gz",
-    files = LICENSE_TARGETS,
+    files = select({
+        ":embed_license_targets": LICENSE_TARGETS,
+        "//conditions:default": [],
+    }),
    mode = "0644",
    package_dir = "kubernetes",
    deps = [
@@ -197,14 +211,17 @@ pkg_tar(
    name = "kubernetes",
    extension = "tar.gz",
    files = [
-        "//:Godeps/LICENSES",
+        # TODO: the version file
        "//:README.md",
        "//:Vagrantfile",
        "//cluster:all-srcs",
        "//docs:all-srcs",
        "//examples:all-srcs",
        "//third_party/htpasswd:all-srcs",
-    ],
+    ] + select({
+        ":embed_license_targets": ["//:Godeps/LICENSES"],
+        "//conditions:default": [],
+    }),
    package_dir = "kubernetes",
    strip_prefix = "//",
    deps = [