Commit a2f2e1d4 authored by Tim Allclair's avatar Tim Allclair

Name change: s/timstclair/tallclair/

parent 07449649
......@@ -52,7 +52,7 @@ aliases:
- pmorie
- resouer
- sjpotter
- timstclair
- tallclair
- tmrts
- vishh
- yifan-gu
......
......@@ -33,7 +33,7 @@ reviewers:
- pwittrock
- roberthbailey
- ncdc
- timstclair
- tallclair
- yifan-gu
- eparis
- mwielgus
......
......@@ -111,7 +111,7 @@ def get_maintainers():
"nikhiljindal", "piosz", "pmorie", "pwittrock", "Q-Lee", "quinton-hoole",
"Random-Liu", "rmmh", "roberthbailey", "saad-ali", "smarterclayton",
"soltysh", "spxtr", "sttts", "thelinuxfoundation", "thockin",
"timothysc", "timstclair", "vishh", "wojtek-t", "xiang90", "yifan-gu",
"timothysc", "tallclair", "vishh", "wojtek-t", "xiang90", "yifan-gu",
"yujuhong", "zmerlynn"}
return sorted(ret - SKIP_MAINTAINERS)
......
......@@ -33,7 +33,7 @@ reviewers:
- pwittrock
- roberthbailey
- ncdc
- timstclair
- tallclair
- yifan-gu
- eparis
- mwielgus
......
......@@ -10,7 +10,7 @@ reviewers:
- nikhiljindal
- bprashanth
- erictune
- timstclair
- tallclair
- eparis
- soltysh
- madhusudancs
......
......@@ -20,7 +20,7 @@ reviewers:
- justinsb
- pwittrock
- roberthbailey
- timstclair
- tallclair
- yifan-gu
- eparis
- soltysh
......
......@@ -27,7 +27,7 @@ reviewers:
- justinsb
- roberthbailey
- ncdc
- timstclair
- tallclair
- eparis
- timothysc
- piosz
......
......@@ -26,7 +26,7 @@ reviewers:
- justinsb
- pwittrock
- roberthbailey
- timstclair
- tallclair
- eparis
- soltysh
- piosz
......
......@@ -29,7 +29,7 @@ reviewers:
- justinsb
- pwittrock
- ncdc
- timstclair
- tallclair
- yifan-gu
- eparis
- mwielgus
......
......@@ -9,7 +9,7 @@ reviewers:
- sttts
- saad-ali
- ncdc
- timstclair
- tallclair
- timothysc
- dims
- errordeveloper
......
......@@ -19,7 +19,7 @@ reviewers:
- janetkuo
- justinsb
- ncdc
- timstclair
- tallclair
- mwielgus
- timothysc
- soltysh
......
......@@ -33,7 +33,7 @@ reviewers:
- justinsb
- roberthbailey
- ncdc
- timstclair
- tallclair
- yifan-gu
- eparis
- mwielgus
......
......@@ -22,7 +22,7 @@ reviewers:
- zmerlynn
- janetkuo
- ncdc
- timstclair
- tallclair
- mwielgus
- timothysc
- feiskyer
......
......@@ -28,7 +28,7 @@ const (
// // alpha: v1.X
// MyFeature utilfeature.Feature = "MyFeature"
// owner: @timstclair
// owner: @tallclair
// beta: v1.4
AppArmor utilfeature.Feature = "AppArmor"
......@@ -44,7 +44,7 @@ const (
// alpha: v1.4
DynamicKubeletConfig utilfeature.Feature = "DynamicKubeletConfig"
// owner: timstclair
// owner: tallclair
// alpha: v1.5
//
// StreamingProxyRedirects controls whether the apiserver should intercept (and follow)
......
......@@ -2,7 +2,7 @@ approvers:
- Random-Liu
- dchen1107
- derekwaynecarr
- timstclair
- tallclair
- vishh
- yujuhong
reviewers:
......
......@@ -121,7 +121,7 @@ func (ds *dockerService) PortForward(req *runtimeapi.PortForwardRequest) (*runti
if err != nil {
return nil, err
}
// TODO(timstclair): Verify that ports are exposed.
// TODO(tallclair): Verify that ports are exposed.
return ds.streamingServer.GetPortForward(req)
}
......
......@@ -696,7 +696,7 @@ func (kl *Kubelet) setNodeReadyCondition(node *v1.Node) {
}
// Append AppArmor status if it's enabled.
// TODO(timstclair): This is a temporary message until node feature reporting is added.
// TODO(tallclair): This is a temporary message until node feature reporting is added.
if newNodeReadyCondition.Status == v1.ConditionTrue &&
kl.appArmorValidator != nil && kl.appArmorValidator.ValidateHost() == nil {
newNodeReadyCondition.Message = fmt.Sprintf("%s. AppArmor enabled", newNodeReadyCondition.Message)
......
......@@ -1418,7 +1418,7 @@ func (kl *Kubelet) RunInContainer(podFullName string, podUID types.UID, containe
if container == nil {
return nil, fmt.Errorf("container not found (%q)", containerName)
}
// TODO(timstclair): Pass a proper timeout value.
// TODO(tallclair): Pass a proper timeout value.
return kl.runner.RunInContainer(container.ID, cmd, 0)
}
......
......@@ -764,7 +764,7 @@ func (m *kubeGenericRuntimeManager) GetAttach(id kubecontainer.ContainerID, stdi
// RunInContainer synchronously executes the command in the container, and returns the output.
func (m *kubeGenericRuntimeManager) RunInContainer(id kubecontainer.ContainerID, cmd []string, timeout time.Duration) ([]byte, error) {
stdout, stderr, err := m.runtimeService.ExecSync(id.ID, cmd, 0)
// NOTE(timstclair): This does not correctly interleave stdout & stderr, but should be sufficient
// NOTE(tallclair): This does not correctly interleave stdout & stderr, but should be sufficient
// for logging purposes. A combined output option will need to be added to the ExecSyncRequest
// if more precise output ordering is ever required.
return append(stdout, stderr...), err
......
......@@ -55,7 +55,7 @@ func (hr *HandlerRunner) Run(containerID kubecontainer.ContainerID, pod *v1.Pod,
switch {
case handler.Exec != nil:
var msg string
// TODO(timstclair): Pass a proper timeout value.
// TODO(tallclair): Pass a proper timeout value.
output, err := hr.commandRunner.RunInContainer(containerID, handler.Exec.Command, 0)
if err != nil {
msg := fmt.Sprintf("Exec lifecycle hook (%v) for Container %q in Pod %q failed - error: %v, message: %q", handler.Exec.Command, container.Name, format.Pod(pod), err, string(output))
......
......@@ -73,7 +73,7 @@ func (sp *summaryProviderImpl) Get() (*stats.Summary, error) {
}
}
// TODO(timstclair): Consider returning a best-effort response if any of the following errors
// TODO(tallclair): Consider returning a best-effort response if any of the following errors
// occur.
node, err := sp.provider.GetNode()
if err != nil {
......
......@@ -101,7 +101,7 @@ var DefaultConfig = Config{
SupportedPortForwardProtocols: portforward.SupportedProtocols,
}
// TODO(timstclair): Add auth(n/z) interface & handling.
// TODO(tallclair): Add auth(n/z) interface & handling.
func NewServer(config Config, runtime Runtime) (Server, error) {
s := &server{
config: config,
......@@ -193,7 +193,7 @@ func (s *server) GetPortForward(req *runtimeapi.PortForwardRequest) (*runtimeapi
func (s *server) Start(stayUp bool) error {
if !stayUp {
// TODO(timstclair): Implement this.
// TODO(tallclair): Implement this.
return errors.New("stayUp=false is not yet implemented")
}
......@@ -210,7 +210,7 @@ func (s *server) Start(stayUp bool) error {
}
func (s *server) Stop() error {
// TODO(timstclair): Implement this.
// TODO(tallclair): Implement this.
return errors.New("not yet implemented")
}
......
......@@ -31,7 +31,7 @@ reviewers:
- justinsb
- roberthbailey
- ncdc
- timstclair
- tallclair
- mwielgus
- timothysc
- soltysh
......
......@@ -29,7 +29,7 @@ reviewers:
- pwittrock
- roberthbailey
- ncdc
- timstclair
- tallclair
- eparis
- mwielgus
- timothysc
......
......@@ -225,7 +225,7 @@ func (s *simpleProvider) ValidatePodSecurityContext(pod *api.Pod, fldPath *field
allErrs = append(allErrs, s.strategies.SysctlsStrategy.Validate(pod)...)
// TODO(timstclair): ValidatePodSecurityContext should be renamed to ValidatePod since its scope
// TODO(tallclair): ValidatePodSecurityContext should be renamed to ValidatePod since its scope
// is not limited to the PodSecurityContext.
if len(pod.Spec.Volumes) > 0 && !psputil.PSPAllowsAllVolumes(s.psp) {
allowedVolumes := psputil.FSTypeToStringSet(s.psp.Spec.Volumes)
......
approvers:
- deads2k
- liggitt
- timstclair
- tallclair
reviewers:
- deads2k
- liggitt
- timstclair
- tallclair
approvers:
- timstclair
- tallclair
- liggitt
- deads2k
reviewers:
- timstclair
- tallclair
- liggitt
- deads2k
- ericchiang
......@@ -18,4 +18,4 @@ reviewers:
- gmarek
- sttts
- ncdc
- timstclair
- tallclair
......@@ -14,7 +14,7 @@ reviewers:
- erictune
- saad-ali
- janetkuo
- timstclair
- tallclair
- eparis
- timothysc
- dims
......
......@@ -7,7 +7,7 @@ reviewers:
- mikedanese
- saad-ali
- janetkuo
- timstclair
- tallclair
- eparis
- timothysc
- jbeda
......
......@@ -13,5 +13,5 @@ reviewers:
- liggitt
- sttts
- ncdc
- timstclair
- tallclair
- timothysc
......@@ -27,14 +27,14 @@ const (
// // alpha: v1.4
// MyFeature() bool
// owner: timstclair
// owner: tallclair
// alpha: v1.5
//
// StreamingProxyRedirects controls whether the apiserver should intercept (and follow)
// redirects from the backend (Kubelet) for streaming requests (exec/attach/port-forward).
StreamingProxyRedirects utilfeature.Feature = "StreamingProxyRedirects"
// owner: timstclair
// owner: tallclair
// alpha: v1.7
//
// AdvancedAuditing enables a much more general API auditing pipeline, which includes support for
......
......@@ -13,7 +13,7 @@ reviewers:
- mikedanese
- liggitt
- ncdc
- timstclair
- tallclair
- timothysc
- hongchaodeng
- krousey
......
......@@ -12,7 +12,7 @@ reviewers:
- luxas
- janetkuo
- roberthbailey
- timstclair
- tallclair
- timothysc
- dims
- hongchaodeng
......
......@@ -33,7 +33,7 @@ reviewers:
- justinsb
- roberthbailey
- ncdc
- timstclair
- tallclair
- yifan-gu
- eparis
- mwielgus
......
approvers:
- Random-Liu
- timstclair
- tallclair
- vishh
- derekwaynecarr
reviewers:
......
......@@ -200,7 +200,7 @@ func expectSoftRejection(status v1.PodStatus) {
}
func isAppArmorEnabled() bool {
// TODO(timstclair): Pass this through the image setup rather than hardcoding.
// TODO(tallclair): Pass this through the image setup rather than hardcoding.
if strings.Contains(framework.TestContext.NodeName, "-gci-dev-") {
gciVersionRe := regexp.MustCompile("-gci-dev-([0-9]+)-")
matches := gciVersionRe.FindStringSubmatch(framework.TestContext.NodeName)
......
......@@ -120,7 +120,7 @@ ESIPP should work for type=LoadBalancer,MrHohn,1,network
ESIPP should work for type=NodePort,MrHohn,1,network
ESIPP should work from pods,MrHohn,1,network
Empty starts a pod,childsb,1,
"EmptyDir volumes should support (non-root,0644,default)",timstclair,1,node
"EmptyDir volumes should support (non-root,0644,default)",tallclair,1,node
"EmptyDir volumes should support (non-root,0644,tmpfs)",spxtr,1,node
"EmptyDir volumes should support (non-root,0666,default)",dchen1107,1,node
"EmptyDir volumes should support (non-root,0666,tmpfs)",apelisse,1,node
......@@ -291,7 +291,7 @@ Loadbalancing: L7 Nginx should conform to Ingress spec,ncdc,1,network
"Logging soak should survive logging 1KB every * seconds, for a duration of *, scaling up to * pods per node",justinsb,1,node
"MemoryEviction when there is memory pressure should evict pods in the correct order (besteffort first, then burstable, then guaranteed)",ixdy,1,node
Mesos applies slave attributes as labels,justinsb,1,apps
Mesos schedules pods annotated with roles on correct slaves,timstclair,1,apps
Mesos schedules pods annotated with roles on correct slaves,tallclair,1,apps
Mesos starts static pods on every node in the mesos cluster,lavalamp,1,apps
MetricsGrabber should grab all metrics from API server.,gmarek,0,instrumentation
MetricsGrabber should grab all metrics from a ControllerManager.,gmarek,0,instrumentation
......@@ -395,7 +395,7 @@ PrivilegedPod should enable privileged commands,derekwaynecarr,0,node
Probing container should *not* be restarted with a /healthz http liveness probe,Random-Liu,0,node
"Probing container should *not* be restarted with a exec ""cat /tmp/health"" liveness probe",Random-Liu,0,node
Probing container should be restarted with a /healthz http liveness probe,Random-Liu,0,node
Probing container should be restarted with a docker exec liveness probe with timeout,timstclair,0,node
Probing container should be restarted with a docker exec liveness probe with timeout,tallclair,0,node
"Probing container should be restarted with a exec ""cat /tmp/health"" liveness probe",Random-Liu,0,node
Probing container should have monotonically increasing restart count,Random-Liu,0,node
Probing container with readiness probe should not be ready before initial delay and never restart,Random-Liu,0,node
......@@ -424,7 +424,7 @@ Projected should provide node allocatable (memory) as default memory limit if th
Projected should provide podname as non-root with fsgroup,fabioy,1,storage
Projected should provide podname as non-root with fsgroup and defaultMode,gmarek,1,storage
Projected should provide podname only,vishh,1,storage
Projected should set DefaultMode on files,timstclair,1,storage
Projected should set DefaultMode on files,tallclair,1,storage
Projected should set mode on item file,gmarek,1,storage
Projected should update annotations on modification,janetkuo,1,storage
Projected should update labels on modification,xiang90,1,storage
......@@ -442,7 +442,7 @@ Reboot each node by ordering clean reboot and ensure they function upon restart,
Reboot each node by ordering unclean reboot and ensure they function upon restart,quinton-hoole,0,node
Reboot each node by switching off the network interface and ensure they function upon switch on,quinton-hoole,0,node
Reboot each node by triggering kernel panic and ensure they function upon restart,quinton-hoole,0,node
Redis should create and stop redis servers,timstclair,1,apps
Redis should create and stop redis servers,tallclair,1,apps
ReplicaSet should serve a basic image on each replica with a private image,pmorie,1,apps
ReplicaSet should serve a basic image on each replica with a public image,krousey,0,apps
ReplicaSet should surface a failure condition on a common issue like exceeded quota,kargakis,0,apps
......@@ -451,13 +451,13 @@ ReplicationController should serve a basic image on each replica with a public i
ReplicationController should surface a failure condition on a common issue like exceeded quota,kargakis,0,apps
Rescheduler should ensure that critical pod is scheduled in case there is no resources available,mtaufen,1,apps
Resource-usage regular resource usage tracking resource tracking for * pods per node,janetkuo,1,
ResourceQuota should create a ResourceQuota and capture the life of a configMap.,timstclair,1,api-machinery
ResourceQuota should create a ResourceQuota and capture the life of a configMap.,tallclair,1,api-machinery
ResourceQuota should create a ResourceQuota and capture the life of a persistent volume claim with a storage class.,derekwaynecarr,0,api-machinery
ResourceQuota should create a ResourceQuota and capture the life of a persistent volume claim.,bgrant0607,1,api-machinery
ResourceQuota should create a ResourceQuota and capture the life of a pod.,pmorie,1,api-machinery
ResourceQuota should create a ResourceQuota and capture the life of a replication controller.,rrati,0,api-machinery
ResourceQuota should create a ResourceQuota and capture the life of a secret.,ncdc,1,api-machinery
ResourceQuota should create a ResourceQuota and capture the life of a service.,timstclair,1,api-machinery
ResourceQuota should create a ResourceQuota and capture the life of a service.,tallclair,1,api-machinery
ResourceQuota should create a ResourceQuota and ensure its status is promptly calculated.,krousey,1,api-machinery
ResourceQuota should verify ResourceQuota with best effort scope.,mml,1,api-machinery
ResourceQuota should verify ResourceQuota with terminating scopes.,ncdc,1,api-machinery
......@@ -712,7 +712,7 @@ k8s.io/kubernetes/pkg/kubectl/resource,caesarxuchao,1,
k8s.io/kubernetes/pkg/kubelet,vishh,0,
k8s.io/kubernetes/pkg/kubelet/cadvisor,sttts,1,
k8s.io/kubernetes/pkg/kubelet/certificate,mikedanese,1,
k8s.io/kubernetes/pkg/kubelet/client,timstclair,1,
k8s.io/kubernetes/pkg/kubelet/client,tallclair,1,
k8s.io/kubernetes/pkg/kubelet/cm,vishh,0,
k8s.io/kubernetes/pkg/kubelet/config,mikedanese,1,
k8s.io/kubernetes/pkg/kubelet/container,yujuhong,0,
......@@ -736,9 +736,9 @@ k8s.io/kubernetes/pkg/kubelet/qos,vishh,0,
k8s.io/kubernetes/pkg/kubelet/rkt,apelisse,1,
k8s.io/kubernetes/pkg/kubelet/rktshim,mml,1,
k8s.io/kubernetes/pkg/kubelet/secret,kevin-wangzefeng,1,
k8s.io/kubernetes/pkg/kubelet/server,timstclair,0,
k8s.io/kubernetes/pkg/kubelet/server,tallclair,0,
k8s.io/kubernetes/pkg/kubelet/server/portforward,rkouj,0,
k8s.io/kubernetes/pkg/kubelet/server/stats,timstclair,0,
k8s.io/kubernetes/pkg/kubelet/server/stats,tallclair,0,
k8s.io/kubernetes/pkg/kubelet/server/streaming,caesarxuchao,1,
k8s.io/kubernetes/pkg/kubelet/status,mwielgus,1,
k8s.io/kubernetes/pkg/kubelet/sysctl,piosz,1,
......@@ -749,7 +749,7 @@ k8s.io/kubernetes/pkg/kubelet/util/format,ncdc,1,
k8s.io/kubernetes/pkg/kubelet/util/queue,yujuhong,0,
k8s.io/kubernetes/pkg/kubelet/volumemanager,rrati,0,
k8s.io/kubernetes/pkg/kubelet/volumemanager/cache,janetkuo,1,
k8s.io/kubernetes/pkg/kubelet/volumemanager/reconciler,timstclair,1,
k8s.io/kubernetes/pkg/kubelet/volumemanager/reconciler,tallclair,1,
k8s.io/kubernetes/pkg/master,fabioy,1,
k8s.io/kubernetes/pkg/master/tunneler,jsafrane,1,
k8s.io/kubernetes/pkg/probe/exec,bgrant0607,1,
......@@ -894,7 +894,7 @@ k8s.io/kubernetes/pkg/volume/flexvolume,Q-Lee,1,
k8s.io/kubernetes/pkg/volume/flocker,jbeda,1,
k8s.io/kubernetes/pkg/volume/gce_pd,saad-ali,0,
k8s.io/kubernetes/pkg/volume/git_repo,davidopp,1,
k8s.io/kubernetes/pkg/volume/glusterfs,timstclair,1,
k8s.io/kubernetes/pkg/volume/glusterfs,tallclair,1,
k8s.io/kubernetes/pkg/volume/host_path,jbeda,1,
k8s.io/kubernetes/pkg/volume/iscsi,cjcullen,1,
k8s.io/kubernetes/pkg/volume/nfs,justinsb,1,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment