Merge pull request #5714 from fgrzadkowski/update_status_on_change

cmd/integration/integration.go

@@ -224,7 +224,6 @@ func startComponents(firstManifestURL, secondManifestURL, apiVersion string) (st
 	configFilePath := makeTempDirOrDie("config", testRootDir)
 	glog.Infof("Using %s as root dir for kubelet #1", testRootDir)
 	kcfg := kubeletapp.SimpleKubelet(cl, &fakeDocker1, machineList[0], testRootDir, firstManifestURL, "127.0.0.1", 10250, api.NamespaceDefault, empty_dir.ProbeVolumePlugins(), nil, cadvisorInterface, configFilePath)
-	kcfg.PodStatusUpdateFrequency = 1 * time.Second
 	kubeletapp.RunKubelet(kcfg)
 	// Kubelet (machine)
 	// Create a second kubelet so that the guestbook example's two redis slaves both
@@ -232,7 +231,6 @@ func startComponents(firstManifestURL, secondManifestURL, apiVersion string) (st
 	testRootDir = makeTempDirOrDie("kubelet_integ_2.", "")
 	glog.Infof("Using %s as root dir for kubelet #2", testRootDir)
 	kcfg = kubeletapp.SimpleKubelet(cl, &fakeDocker2, machineList[1], testRootDir, secondManifestURL, "127.0.0.1", 10251, api.NamespaceDefault, empty_dir.ProbeVolumePlugins(), nil, cadvisorInterface, "")
-	kcfg.PodStatusUpdateFrequency = 1 * time.Second
 	kubeletapp.RunKubelet(kcfg)
 	return apiServer.URL, configFilePath
 }

cmd/kubelet/app/server.go

@@ -52,7 +52,6 @@ type KubeletServer struct {
 	FileCheckFrequency             time.Duration
 	HTTPCheckFrequency             time.Duration
 	StatusUpdateFrequency          time.Duration
-	PodStatusUpdateFrequency       time.Duration
 	ManifestURL                    string
 	EnableServer                   bool
 	Address                        util.IP
@@ -86,14 +85,13 @@ type KubeletServer struct {
 // NewKubeletServer will create a new KubeletServer with default values.
 func NewKubeletServer() *KubeletServer {
 	return &KubeletServer{
-		SyncFrequency:            10 * time.Second,
-		FileCheckFrequency:       20 * time.Second,
-		HTTPCheckFrequency:       20 * time.Second,
-		StatusUpdateFrequency:    20 * time.Second,
-		PodStatusUpdateFrequency: 2 * time.Minute,
-		EnableServer:             true,
-		Address:                  util.IP(net.ParseIP("127.0.0.1")),
-		Port:                     ports.KubeletPort,
+		SyncFrequency:         10 * time.Second,
+		FileCheckFrequency:    20 * time.Second,
+		HTTPCheckFrequency:    20 * time.Second,
+		StatusUpdateFrequency: 20 * time.Second,
+		EnableServer:          true,
+		Address:               util.IP(net.ParseIP("127.0.0.1")),
+		Port:                  ports.KubeletPort,
 		PodInfraContainerImage:      kubelet.PodInfraContainerImage,
 		RootDirectory:               defaultRootDir,
 		RegistryBurst:               10,
@@ -115,7 +113,6 @@ func (s *KubeletServer) AddFlags(fs *pflag.FlagSet) {
 	fs.StringVar(&s.Config, "config", s.Config, "Path to the config file or directory of files")
 	fs.DurationVar(&s.SyncFrequency, "sync_frequency", s.SyncFrequency, "Max period between synchronizing running containers and config")
 	fs.DurationVar(&s.StatusUpdateFrequency, "status_update_frequency", s.StatusUpdateFrequency, "Duration between posting node status to master")
-	fs.DurationVar(&s.PodStatusUpdateFrequency, "pod_status_update_frequency", s.PodStatusUpdateFrequency, "Duration between posting pod status updates to the master")
 	fs.DurationVar(&s.FileCheckFrequency, "file_check_frequency", s.FileCheckFrequency, "Duration between checking config files for new data")
 	fs.DurationVar(&s.HTTPCheckFrequency, "http_check_frequency", s.HTTPCheckFrequency, "Duration between checking http for new data")
 	fs.StringVar(&s.ManifestURL, "manifest_url", s.ManifestURL, "URL for accessing the container manifest")
@@ -183,7 +180,6 @@ func (s *KubeletServer) Run(_ []string) error {
 		ConfigFile:                     s.Config,
 		ManifestURL:                    s.ManifestURL,
 		StatusUpdateFrequency:          s.StatusUpdateFrequency,
-		PodStatusUpdateFrequency:       s.PodStatusUpdateFrequency,
 		FileCheckFrequency:             s.FileCheckFrequency,
 		HTTPCheckFrequency:             s.HTTPCheckFrequency,
 		PodInfraContainerImage:         s.PodInfraContainerImage,
@@ -283,24 +279,23 @@ func SimpleKubelet(client *client.Client,
 		RootDirectory:          rootDir,
 		ManifestURL:            manifestURL,
 		PodInfraContainerImage: kubelet.PodInfraContainerImage,
-		Port:                     port,
-		Address:                  util.IP(net.ParseIP(address)),
-		EnableServer:             true,
-		EnableDebuggingHandlers:  true,
-		HTTPCheckFrequency:       1 * time.Second,
-		FileCheckFrequency:       1 * time.Second,
-		StatusUpdateFrequency:    3 * time.Second,
-		PodStatusUpdateFrequency: 2 * time.Minute,
-		SyncFrequency:            3 * time.Second,
-		MinimumGCAge:             10 * time.Second,
-		MaxPerPodContainerCount:  5,
-		MaxContainerCount:        100,
-		MasterServiceNamespace:   masterServiceNamespace,
-		VolumePlugins:            volumePlugins,
-		TLSOptions:               tlsOptions,
-		CadvisorInterface:        cadvisorInterface,
-		ConfigFile:               configFilePath,
-		ImageGCPolicy:            imageGCPolicy,
+		Port:                    port,
+		Address:                 util.IP(net.ParseIP(address)),
+		EnableServer:            true,
+		EnableDebuggingHandlers: true,
+		HTTPCheckFrequency:      1 * time.Second,
+		FileCheckFrequency:      1 * time.Second,
+		StatusUpdateFrequency:   3 * time.Second,
+		SyncFrequency:           3 * time.Second,
+		MinimumGCAge:            10 * time.Second,
+		MaxPerPodContainerCount: 5,
+		MaxContainerCount:       100,
+		MasterServiceNamespace:  masterServiceNamespace,
+		VolumePlugins:           volumePlugins,
+		TLSOptions:              tlsOptions,
+		CadvisorInterface:       cadvisorInterface,
+		ConfigFile:              configFilePath,
+		ImageGCPolicy:           imageGCPolicy,
 	}
 	return &kcfg
 }
@@ -386,7 +381,6 @@ type KubeletConfig struct {
 	ConfigFile                     string
 	ManifestURL                    string
 	StatusUpdateFrequency          time.Duration
-	PodStatusUpdateFrequency       time.Duration
 	FileCheckFrequency             time.Duration
 	HTTPCheckFrequency             time.Duration
 	Hostname                       string
@@ -453,7 +447,6 @@ func createAndInitKubelet(kc *KubeletConfig, pc *config.PodConfig) (*kubelet.Kub
 		kc.Recorder,
 		kc.CadvisorInterface,
 		kc.StatusUpdateFrequency,
-		kc.PodStatusUpdateFrequency,
 		kc.ImageGCPolicy)
 
 	if err != nil {

pkg/kubelet/handlers.go

@@ -71,7 +71,7 @@ func ResolvePort(portReference util.IntOrString, container *api.Container) (int,
 func (h *httpActionHandler) Run(podFullName string, uid types.UID, container *api.Container, handler *api.Handler) error {
 	host := handler.HTTPGet.Host
 	if len(host) == 0 {
-		status, err := h.kubelet.GetPodStatus(podFullName, uid)
+		status, err := h.kubelet.GetPodStatus(podFullName)
 		if err != nil {
 			glog.Errorf("Unable to get pod info, event handlers may be invalid.")
 			return err

pkg/kubelet/kubelet_test.go

@@ -99,7 +99,7 @@ func newTestKubelet(t *testing.T) *TestKubelet {
 	kubelet.nodeLister = testNodeLister{}
 	kubelet.readiness = newReadinessStates()
 	kubelet.recorder = fakeRecorder
-	kubelet.podStatuses = map[string]api.PodStatus{}
+	kubelet.statusManager = newStatusManager(fakeKubeClient)
 	if err := kubelet.setupDataDirs(); err != nil {
 		t.Fatalf("can't initialize kubelet data dirs: %v", err)
 	}
@@ -2866,13 +2866,10 @@ func TestHandlePortConflicts(t *testing.T) {
 	conflictedPodName := GetPodFullName(&pods[0])
 
 	kl.handleNotFittingPods(pods)
-	if len(kl.podStatuses) != 1 {
-		t.Fatalf("expected length of status map to be 1. Got map %#v.", kl.podStatuses)
-	}
 	// Check pod status stored in the status map.
-	status, ok := kl.podStatuses[conflictedPodName]
-	if !ok {
-		t.Fatalf("status of pod %q is not found in the status map.", conflictedPodName)
+	status, err := kl.GetPodStatus(conflictedPodName)
+	if err != nil {
+		t.Fatalf("status of pod %q is not found in the status map: ", conflictedPodName, err)
 	}
 	if status.Phase != api.PodFailed {
 		t.Fatalf("expected pod status %q. Got %q.", api.PodFailed, status.Phase)
@@ -2880,9 +2877,9 @@ func TestHandlePortConflicts(t *testing.T) {
 
 	// Check if we can retrieve the pod status from GetPodStatus().
 	kl.podManager.SetPods(pods)
-	status, err := kl.GetPodStatus(conflictedPodName, "")
+	status, err = kl.GetPodStatus(conflictedPodName)
 	if err != nil {
-		t.Fatalf("unable to retrieve pod status for pod %q: #v.", conflictedPodName, err)
+		t.Fatalf("unable to retrieve pod status for pod %q: %#v.", conflictedPodName, err)
 	}
 	if status.Phase != api.PodFailed {
 		t.Fatalf("expected pod status %q. Got %q.", api.PodFailed, status.Phase)
@@ -2919,13 +2916,10 @@ func TestHandleNodeSelector(t *testing.T) {
 	notfittingPodName := GetPodFullName(&pods[0])
 
 	kl.handleNotFittingPods(pods)
-	if len(kl.podStatuses) != 1 {
-		t.Fatalf("expected length of status map to be 1. Got map %#v.", kl.podStatuses)
-	}
 	// Check pod status stored in the status map.
-	status, ok := kl.podStatuses[notfittingPodName]
-	if !ok {
-		t.Fatalf("status of pod %q is not found in the status map.", notfittingPodName)
+	status, err := kl.GetPodStatus(notfittingPodName)
+	if err != nil {
+		t.Fatalf("status of pod %q is not found in the status map: %#v", notfittingPodName, err)
 	}
 	if status.Phase != api.PodFailed {
 		t.Fatalf("expected pod status %q. Got %q.", api.PodFailed, status.Phase)
@@ -2933,9 +2927,9 @@ func TestHandleNodeSelector(t *testing.T) {
 
 	// Check if we can retrieve the pod status from GetPodStatus().
 	kl.podManager.SetPods(pods)
-	status, err := kl.GetPodStatus(notfittingPodName, "")
+	status, err = kl.GetPodStatus(notfittingPodName)
 	if err != nil {
-		t.Fatalf("unable to retrieve pod status for pod %q: #v.", notfittingPodName, err)
+		t.Fatalf("unable to retrieve pod status for pod %q: %#v.", notfittingPodName, err)
 	}
 	if status.Phase != api.PodFailed {
 		t.Fatalf("expected pod status %q. Got %q.", api.PodFailed, status.Phase)
@@ -2978,13 +2972,10 @@ func TestHandleMemExceeded(t *testing.T) {
 	notfittingPodName := GetPodFullName(&pods[0])
 
 	kl.handleNotFittingPods(pods)
-	if len(kl.podStatuses) != 1 {
-		t.Fatalf("expected length of status map to be 1. Got map %#v.", kl.podStatuses)
-	}
 	// Check pod status stored in the status map.
-	status, ok := kl.podStatuses[notfittingPodName]
-	if !ok {
-		t.Fatalf("status of pod %q is not found in the status map.", notfittingPodName)
+	status, err := kl.GetPodStatus(notfittingPodName)
+	if err != nil {
+		t.Fatalf("status of pod %q is not found in the status map: ", notfittingPodName, err)
 	}
 	if status.Phase != api.PodFailed {
 		t.Fatalf("expected pod status %q. Got %q.", api.PodFailed, status.Phase)
@@ -2992,7 +2983,7 @@ func TestHandleMemExceeded(t *testing.T) {
 
 	// Check if we can retrieve the pod status from GetPodStatus().
 	kl.podManager.SetPods(pods)
-	status, err := kl.GetPodStatus(notfittingPodName, "")
+	status, err = kl.GetPodStatus(notfittingPodName)
 	if err != nil {
 		t.Fatalf("unable to retrieve pod status for pod %q: #v.", notfittingPodName, err)
 	}
@@ -3001,24 +2992,25 @@ func TestHandleMemExceeded(t *testing.T) {
 	}
 }
 
+// TODO(filipg): This test should be removed once StatusSyncer can do garbage collection without external signal.
 func TestPurgingObsoleteStatusMapEntries(t *testing.T) {
 	testKubelet := newTestKubelet(t)
 	testKubelet.fakeCadvisor.On("MachineInfo").Return(&cadvisorApi.MachineInfo{}, nil)
 
 	kl := testKubelet.kubelet
 	pods := []api.Pod{
-		{Spec: api.PodSpec{Containers: []api.Container{{Ports: []api.ContainerPort{{HostPort: 80}}}}}},
-		{Spec: api.PodSpec{Containers: []api.Container{{Ports: []api.ContainerPort{{HostPort: 80}}}}}},
+		{ObjectMeta: api.ObjectMeta{Name: "pod1"}, Spec: api.PodSpec{Containers: []api.Container{{Ports: []api.ContainerPort{{HostPort: 80}}}}}},
+		{ObjectMeta: api.ObjectMeta{Name: "pod2"}, Spec: api.PodSpec{Containers: []api.Container{{Ports: []api.ContainerPort{{HostPort: 80}}}}}},
 	}
 	// Run once to populate the status map.
 	kl.handleNotFittingPods(pods)
-	if len(kl.podStatuses) != 1 {
-		t.Fatalf("expected length of status map to be 1. Got map %#v.", kl.podStatuses)
+	if _, err := kl.GetPodStatus(BuildPodFullName("pod2", "")); err != nil {
+		t.Fatalf("expected to have status cached for %q: %v", "pod2", err)
 	}
 	// Sync with empty pods so that the entry in status map will be removed.
 	kl.SyncPods([]api.Pod{}, emptyPodUIDs, *newMirrorPods(), time.Now())
-	if len(kl.podStatuses) != 0 {
-		t.Fatalf("expected length of status map to be 0. Got map %#v.", kl.podStatuses)
+	if _, err := kl.GetPodStatus(BuildPodFullName("pod2", "")); err == nil {
+		t.Fatalf("expected to not have status cached for %q: %v", "pod2", err)
 	}
 }
 

pkg/kubelet/runonce_test.go

@@ -77,8 +77,8 @@ func TestRunOnce(t *testing.T) {
 		rootDirectory: "/tmp/kubelet",
 		recorder:      &record.FakeRecorder{},
 		cadvisor:      cadvisor,
-		podStatuses:   make(map[string]api.PodStatus),
 		nodeLister:    testNodeLister{},
+		statusManager: newStatusManager(nil),
 	}
 
 	kb.networkPlugin, _ = network.InitNetworkPlugin([]network.NetworkPlugin{}, "", network.NewFakeHost(nil))

pkg/kubelet/server.go

@@ -84,7 +84,7 @@ type HostInterface interface {
 	GetCachedMachineInfo() (*cadvisorApi.MachineInfo, error)
 	GetPods() ([]api.Pod, mirrorPods)
 	GetPodByName(namespace, name string) (*api.Pod, bool)
-	GetPodStatus(name string, uid types.UID) (api.PodStatus, error)
+	GetPodStatus(name string) (api.PodStatus, error)
 	RunInContainer(name string, uid types.UID, container string, cmd []string) ([]byte, error)
 	ExecInContainer(name string, uid types.UID, container string, cmd []string, in io.Reader, out, err io.WriteCloser, tty bool) error
 	GetKubeletContainerLogs(podFullName, containerName, tail string, follow bool, stdout, stderr io.Writer) error
@@ -289,7 +289,6 @@ func (s *Server) handlePodStatus(w http.ResponseWriter, req *http.Request, versi
 		return
 	}
 	podID := u.Query().Get("podID")
-	podUID := types.UID(u.Query().Get("UUID"))
 	podNamespace := u.Query().Get("podNamespace")
 	if len(podID) == 0 {
 		http.Error(w, "Missing 'podID=' query entry.", http.StatusBadRequest)
@@ -304,7 +303,7 @@ func (s *Server) handlePodStatus(w http.ResponseWriter, req *http.Request, versi
 		http.Error(w, "Pod does not exist", http.StatusNotFound)
 		return
 	}
-	status, err := s.host.GetPodStatus(GetPodFullName(pod), podUID)
+	status, err := s.host.GetPodStatus(GetPodFullName(pod))
 	if err != nil {
 		s.error(w, err)
 		return

pkg/kubelet/server_test.go

@@ -59,7 +59,7 @@ func (fk *fakeKubelet) GetPodByName(namespace, name string) (*api.Pod, bool) {
 	return fk.podByNameFunc(namespace, name)
 }
 
-func (fk *fakeKubelet) GetPodStatus(name string, uid types.UID) (api.PodStatus, error) {
+func (fk *fakeKubelet) GetPodStatus(name string) (api.PodStatus, error) {
 	return fk.statusFunc(name)
 }
 

pkg/kubelet/status_manager.go

+/*
+Copyright 2014 Google Inc. All rights reserved.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package kubelet
+
+import (
+	"reflect"
+	"sync"
+	"time"
+
+	"github.com/GoogleCloudPlatform/kubernetes/pkg/api"
+	"github.com/GoogleCloudPlatform/kubernetes/pkg/client"
+	"github.com/GoogleCloudPlatform/kubernetes/pkg/util"
+	"github.com/golang/glog"
+)
+
+type podStatusSyncRequest struct {
+	podFullName string
+	status      api.PodStatus
+}
+
+// Updates pod statuses in apiserver. Writes only when new status has changed.
+// All methods are thread-safe.
+type statusManager struct {
+	kubeClient client.Interface
+	// Map from pod full name to sync status of the corresponding pod.
+	podStatusesLock  sync.RWMutex
+	podStatuses      map[string]api.PodStatus
+	podStatusChannel chan podStatusSyncRequest
+}
+
+func newStatusManager(kubeClient client.Interface) *statusManager {
+	return &statusManager{
+		kubeClient:       kubeClient,
+		podStatuses:      make(map[string]api.PodStatus),
+		podStatusChannel: make(chan podStatusSyncRequest, 1000), // Buffer up to 1000 statuses
+	}
+}
+
+func (s *statusManager) Start() {
+	// We can run SyncBatch() often because it will block until we have some updates to send.
+	go util.Forever(s.SyncBatch, 0)
+}
+
+func (s *statusManager) GetPodStatus(podFullName string) (api.PodStatus, bool) {
+	s.podStatusesLock.RLock()
+	defer s.podStatusesLock.RUnlock()
+	status, ok := s.podStatuses[podFullName]
+	return status, ok
+}
+
+func (s *statusManager) SetPodStatus(podFullName string, status api.PodStatus) {
+	s.podStatusesLock.Lock()
+	defer s.podStatusesLock.Unlock()
+	oldStatus, found := s.podStatuses[podFullName]
+	if !found || !reflect.DeepEqual(oldStatus, status) {
+		s.podStatuses[podFullName] = status
+		s.podStatusChannel <- podStatusSyncRequest{podFullName, status}
+	} else {
+		glog.V(3).Infof("Ignoring same pod status for %s - old: %s new: %s", podFullName, oldStatus, status)
+	}
+}
+
+func (s *statusManager) DeletePodStatus(podFullName string) {
+	s.podStatusesLock.Lock()
+	defer s.podStatusesLock.Unlock()
+	delete(s.podStatuses, podFullName)
+}
+
+// TODO(filipg): It'd be cleaner if we can do this without signal from user.
+func (s *statusManager) RemoveOrphanedStatuses(podFullNames map[string]bool) {
+	s.podStatusesLock.Lock()
+	defer s.podStatusesLock.Unlock()
+	for key := range s.podStatuses {
+		if _, ok := podFullNames[key]; !ok {
+			glog.V(5).Infof("Removing %q from status map.", key)
+			delete(s.podStatuses, key)
+		}
+	}
+}
+
+// SyncBatch syncs pods statuses with the apiserver. It will loop until channel
+// s.podStatusChannel is empty for at least 1s.
+func (s *statusManager) SyncBatch() {
+	for {
+		select {
+		case syncRequest := <-s.podStatusChannel:
+			podFullName := syncRequest.podFullName
+			status := syncRequest.status
+			glog.V(3).Infof("Syncing status for %s", podFullName)
+			name, namespace, err := ParsePodFullName(podFullName)
+			if err != nil {
+				glog.Warningf("Cannot parse pod full name %q: %s", podFullName, err)
+			}
+			_, err = s.kubeClient.Pods(namespace).UpdateStatus(name, &status)
+			if err != nil {
+				// We failed to update status. In order to make sure we retry next time
+				// we delete cached value. This may result in an additional update, but
+				// this is ok.
+				s.DeletePodStatus(podFullName)
+				glog.Warningf("Error updating status for pod %q: %v", name, err)
+			} else {
+				glog.V(3).Infof("Status for pod %q updated successfully", name)
+			}
+		case <-time.After(1 * time.Second):
+			return
+		}
+	}
+}

pkg/kubelet/status_manager_test.go

+/*
+Copyright 2014 Google Inc. All rights reserved.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package kubelet
+
+import (
+	"math/rand"
+	"strconv"
+	"testing"
+
+	"github.com/GoogleCloudPlatform/kubernetes/pkg/api"
+	"github.com/GoogleCloudPlatform/kubernetes/pkg/client"
+)
+
+const (
+	podFullName string = "podName_namespace"
+)
+
+func newTestStatusManager() *statusManager {
+	return newStatusManager(&client.Fake{})
+}
+
+func generateRandomMessage() string {
+	return strconv.Itoa(rand.Int())
+}
+
+func getRandomPodStatus() api.PodStatus {
+	return api.PodStatus{
+		Message: generateRandomMessage(),
+	}
+}
+
+func verifyActions(t *testing.T, kubeClient client.Interface, expectedActions []string) {
+	actions := kubeClient.(*client.Fake).Actions
+	if len(actions) != len(expectedActions) {
+		t.Errorf("unexpected actions, got: %s expected: %s", actions, expectedActions)
+		return
+	}
+	for i := 0; i < len(actions); i++ {
+		if actions[i].Action != expectedActions[i] {
+			t.Errorf("unexpected actions, got: %s expected: %s", actions, expectedActions)
+		}
+	}
+}
+
+func TestNewStatus(t *testing.T) {
+	syncer := newTestStatusManager()
+	syncer.SetPodStatus(podFullName, getRandomPodStatus())
+	syncer.SyncBatch()
+	verifyActions(t, syncer.kubeClient, []string{"update-status-pod"})
+}
+
+func TestChangedStatus(t *testing.T) {
+	syncer := newTestStatusManager()
+	syncer.SetPodStatus(podFullName, getRandomPodStatus())
+	syncer.SyncBatch()
+	syncer.SetPodStatus(podFullName, getRandomPodStatus())
+	syncer.SyncBatch()
+	verifyActions(t, syncer.kubeClient, []string{"update-status-pod", "update-status-pod"})
+}
+
+func TestUnchangedStatus(t *testing.T) {
+	syncer := newTestStatusManager()
+	podStatus := getRandomPodStatus()
+	syncer.SetPodStatus(podFullName, podStatus)
+	syncer.SyncBatch()
+	syncer.SetPodStatus(podFullName, podStatus)
+	syncer.SyncBatch()
+	verifyActions(t, syncer.kubeClient, []string{"update-status-pod"})
+}