Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
a29b093a
Unverified
Commit
a29b093a
authored
Oct 06, 2018
by
k8s-ci-robot
Committed by
GitHub
Oct 06, 2018
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #69451 from justinsb/sort_bind_options
Sort bind options in JoinMountOptions
parents
06de51ca
3c4789b4
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
2 deletions
+2
-2
aws_ebs_test.go
pkg/volume/awsebs/aws_ebs_test.go
+1
-1
util.go
pkg/volume/util/util.go
+1
-1
No files found.
pkg/volume/awsebs/aws_ebs_test.go
View file @
a29b093a
...
@@ -371,7 +371,7 @@ func TestMountOptions(t *testing.T) {
...
@@ -371,7 +371,7 @@ func TestMountOptions(t *testing.T) {
t
.
Errorf
(
"Expected success, got: %v"
,
err
)
t
.
Errorf
(
"Expected success, got: %v"
,
err
)
}
}
mountOptions
:=
fakeMounter
.
MountPoints
[
0
]
.
Opts
mountOptions
:=
fakeMounter
.
MountPoints
[
0
]
.
Opts
expectedMountOptions
:=
[]
string
{
"
bind"
,
"_netdev
"
}
expectedMountOptions
:=
[]
string
{
"
_netdev"
,
"bind
"
}
if
!
reflect
.
DeepEqual
(
mountOptions
,
expectedMountOptions
)
{
if
!
reflect
.
DeepEqual
(
mountOptions
,
expectedMountOptions
)
{
t
.
Errorf
(
"Expected mount options to be %v got %v"
,
expectedMountOptions
,
mountOptions
)
t
.
Errorf
(
"Expected mount options to be %v got %v"
,
expectedMountOptions
,
mountOptions
)
}
}
...
...
pkg/volume/util/util.go
View file @
a29b093a
...
@@ -766,7 +766,7 @@ func JoinMountOptions(userOptions []string, systemOptions []string) []string {
...
@@ -766,7 +766,7 @@ func JoinMountOptions(userOptions []string, systemOptions []string) []string {
for
_
,
mountOption
:=
range
systemOptions
{
for
_
,
mountOption
:=
range
systemOptions
{
allMountOptions
.
Insert
(
mountOption
)
allMountOptions
.
Insert
(
mountOption
)
}
}
return
allMountOptions
.
Unsorted
List
()
return
allMountOptions
.
List
()
}
}
// ValidateZone returns:
// ValidateZone returns:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment