Fix volume attach limit flake

It looks like node does become unschedulable for the pod but condition does not get added to the pod in time. Also ginkgo could retry the test and hence it helps to use unique node label for scheduling.

Fix volume attach limit flake
9d78c96e · Hemant Kumar · 18cc1156 · 9d78c96e
Commit 9d78c96e authored Mar 07, 2019 by Hemant Kumar
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

csi_mock_volume.go test/e2e/storage/csi_mock_volume.go +3 -2

No files found.
--- a/test/e2e/storage/csi_mock_volume.go
+++ b/test/e2e/storage/csi_mock_volume.go
@@ -49,7 +49,7 @@ type cleanupFuncs func()

 const (
 	csiNodeLimitUpdateTimeout  = 5 * time.Minute
-	csiPodUnschedulableTimeout = 2 * time.Minute
+	csiPodUnschedulableTimeout = 5 * time.Minute
 )

 var _ = utils.SIGDescribe("CSI mock volume", func() {
@@ -310,7 +310,8 @@ var _ = utils.SIGDescribe("CSI mock volume", func() {
 			// define volume limit to be 2 for this test

 			var err error
-			init(testParameters{nodeSelectorKey: "node-attach-limit-csi", attachLimit: 2})
+			nodeSelectorKey := fmt.Sprintf("attach-limit-csi-%s", f.Namespace.Name)
+			init(testParameters{nodeSelectorKey: nodeSelectorKey, attachLimit: 2})
 			defer cleanup()
 			nodeName := m.config.ClientNodeName
 			attachKey := v1.ResourceName(volumeutil.GetCSIAttachLimitKey(m.provisioner))