Skip to content

K
k3s
Unverified Commit 9c40f5b5 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #62067 from shyamjvs/fix-metrics-printing-bug-in-density

Automatic merge from submit-queue (batch tested with PRs 60983, 62012, 61892, 62051, 62067). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Don't quit without printing API latencies in density test if it failed This is the reason why we are missing quite some data points in our perf-dash graphs for density test (as I mentioned in https://github.com/kubernetes/kubernetes/issues/62064#issuecomment-378235194) ```release-note NONE ``` /cc @wojtek-t
parents 47105a5e a44e3359
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 1 deletion
test/e2e/scalability/density.go
View file @ 9c40f5b5
...@@ -386,7 +386,6 @@ var _ = SIGDescribe("Density", func() { ...@@ -386,7 +386,6 @@ var _ = SIGDescribe("Density", func() {
framework.ExpectNoError(err) framework.ExpectNoError(err)
if err == nil { if err == nil {
summaries = append(summaries, metrics) summaries = append(summaries, metrics)
Expect(highLatencyRequests).NotTo(BeNumerically(">", 0), "There should be no high-latency requests")
} }
// Verify scheduler metrics. // Verify scheduler metrics.
...@@ -401,6 +400,8 @@ var _ = SIGDescribe("Density", func() { ...@@ -401,6 +400,8 @@ var _ = SIGDescribe("Density", func() {
framework.PrintSummaries(summaries, testCaseBaseName) framework.PrintSummaries(summaries, testCaseBaseName)
// Fail if there were some high-latency requests.
Expect(highLatencyRequests).NotTo(BeNumerically(">", 0), "There should be no high-latency requests")
// Fail if more than the allowed threshold of measurements were missing in the latencyTest. // Fail if more than the allowed threshold of measurements were missing in the latencyTest.
Expect(missingMeasurements <= MaxMissingPodStartupMeasurements).To(Equal(true)) Expect(missingMeasurements <= MaxMissingPodStartupMeasurements).To(Equal(true))
}) })
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment