Unverified Commit 99d08010 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #60199 from aleksandra-malinowska/autoscaling-fix-15

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix passing gcloud command output to error check Fix passing gcloud command output to error check. Underlying function from testing library expects interface{} and then type asserts that it's a string, so passing []byte results in errors: ```interface conversion: interface {} is []uint8, not string``` ```release-note NONE ```
parents c85ede51 89f4a09f
...@@ -1298,7 +1298,7 @@ func addNodePool(name string, machineType string, numNodes int) { ...@@ -1298,7 +1298,7 @@ func addNodePool(name string, machineType string, numNodes int) {
"--cluster=" + framework.TestContext.CloudConfig.Cluster} "--cluster=" + framework.TestContext.CloudConfig.Cluster}
output, err := execCmd(getGcloudCommand(args)...).CombinedOutput() output, err := execCmd(getGcloudCommand(args)...).CombinedOutput()
glog.Infof("Creating node-pool %s: %s", name, output) glog.Infof("Creating node-pool %s: %s", name, output)
framework.ExpectNoError(err, output) framework.ExpectNoError(err, string(output))
} }
func deleteNodePool(name string) { func deleteNodePool(name string) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment