Better error check for kubectl cluster-info

In RunClusterInfo, We try to connect to the api service and get some information, but we just ignore the errors from Do().Visit(). We should return the error returned by Do().Visit() so the "kubectl cluster-info" would fail correctly with an error code.

Better error check for kubectl cluster-info
998f3327 · Davanum Srinivas · 6f06408e · 998f3327
Commit 998f3327 authored Oct 22, 2017 by Davanum Srinivas
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

clusterinfo.go pkg/kubectl/cmd/clusterinfo.go +2 -2

No files found.
--- a/pkg/kubectl/cmd/clusterinfo.go
+++ b/pkg/kubectl/cmd/clusterinfo.go
@@ -77,7 +77,7 @@ func RunClusterInfo(f cmdutil.Factory, out io.Writer, cmd *cobra.Command) error 
 		SelectorParam("kubernetes.io/cluster-service=true").
 		ResourceTypeOrNameArgs(false, []string{"services"}...).
 		Latest()
-	b.Do().Visit(func(r *resource.Info, err error) error {
+	err = b.Do().Visit(func(r *resource.Info, err error) error {
 		if err != nil {
 			return err
 		}
@@ -125,7 +125,7 @@ func RunClusterInfo(f cmdutil.Factory, out io.Writer, cmd *cobra.Command) error 
 		return nil
 	})
 	out.Write([]byte("\nTo further debug and diagnose cluster problems, use 'kubectl cluster-info dump'.\n"))
-	return nil
+	return err
 	// TODO consider printing more information about cluster
 }