Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
94c8c724
Unverified
Commit
94c8c724
authored
Feb 26, 2019
by
Kubernetes Prow Robot
Committed by
GitHub
Feb 26, 2019
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #74458 from neolit123/automated-cherry-pick-of-#74454-origin-release-1.13
Automated cherry pick of #74454: kubeadm: fix url validation code
parents
20ff8218
afa970c0
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
4 deletions
+8
-4
validation.go
cmd/kubeadm/app/apis/kubeadm/validation/validation.go
+8
-4
No files found.
cmd/kubeadm/app/apis/kubeadm/validation/validation.go
View file @
94c8c724
...
...
@@ -318,12 +318,16 @@ func ValidateURLs(urls []string, requireHTTPS bool, fldPath *field.Path) field.E
allErrs
:=
field
.
ErrorList
{}
for
_
,
urlstr
:=
range
urls
{
u
,
err
:=
url
.
Parse
(
urlstr
)
if
err
!=
nil
||
u
.
Scheme
==
""
{
allErrs
=
append
(
allErrs
,
field
.
Invalid
(
fldPath
,
urlstr
,
"not a valid URL"
))
if
err
!=
nil
{
allErrs
=
append
(
allErrs
,
field
.
Invalid
(
fldPath
,
urlstr
,
fmt
.
Sprintf
(
"URL parse error: %v"
,
err
)))
continue
}
if
requireHTTPS
&&
u
.
Scheme
!=
"https"
{
allErrs
=
append
(
allErrs
,
field
.
Invalid
(
fldPath
,
urlstr
,
"the URL must be using the HTTPS scheme"
))
}
if
u
.
Scheme
==
""
{
allErrs
=
append
(
allErrs
,
field
.
Invalid
(
fldPath
,
urlstr
,
"the URL without scheme is not allowed"
))
}
}
return
allErrs
}
...
...
@@ -457,7 +461,7 @@ func ValidateSocketPath(socket string, fldPath *field.Path) field.ErrorList {
u
,
err
:=
url
.
Parse
(
socket
)
if
err
!=
nil
{
return
append
(
allErrs
,
field
.
Invalid
(
fldPath
,
socket
,
fmt
.
Sprintf
(
"
url
parsing error: %v"
,
err
)))
return
append
(
allErrs
,
field
.
Invalid
(
fldPath
,
socket
,
fmt
.
Sprintf
(
"
URL
parsing error: %v"
,
err
)))
}
if
u
.
Scheme
==
""
{
...
...
@@ -465,7 +469,7 @@ func ValidateSocketPath(socket string, fldPath *field.Path) field.ErrorList {
return
append
(
allErrs
,
field
.
Invalid
(
fldPath
,
socket
,
fmt
.
Sprintf
(
"path is not absolute: %s"
,
socket
)))
}
}
else
if
u
.
Scheme
!=
kubeadmapiv1beta1
.
DefaultUrlScheme
{
return
append
(
allErrs
,
field
.
Invalid
(
fldPath
,
socket
,
fmt
.
Sprintf
(
"
url
scheme %s is not supported"
,
u
.
Scheme
)))
return
append
(
allErrs
,
field
.
Invalid
(
fldPath
,
socket
,
fmt
.
Sprintf
(
"
URL
scheme %s is not supported"
,
u
.
Scheme
)))
}
return
allErrs
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment