Merge pull request #40342 from louyihua/remove_warning

Automatic merge from submit-queue (batch tested with PRs 40111, 40368, 40342, 40274, 39443) Eliminate "Unknown service type: ExternalName" When creating an ExternalName service, rest.go still generate the warning message "Unknown service type: ExternalName". This should be eliminated as this type of service is supported now.

Merge pull request #40342 from louyihua/remove_warning
8fe7a2de · Kubernetes Submit Queue · GitHub · fd13413b · 352d64ab · 8fe7a2de
Commit 8fe7a2de authored Jan 31, 2017 by Kubernetes Submit Queue Committed by GitHub Jan 31, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

rest.go pkg/registry/core/service/rest.go +2 -0

No files found.
--- a/pkg/registry/core/service/rest.go
+++ b/pkg/registry/core/service/rest.go
@@ -557,6 +557,8 @@ func shouldAssignNodePorts(service *api.Service) bool {
 		return true
 	case api.ServiceTypeClusterIP:
 		return false
+	case api.ServiceTypeExternalName:
+		return false
 	default:
 		glog.Errorf("Unknown service type: %v", service.Spec.Type)
 		return false