Commit 8ea9417a authored by Yang Guo's avatar Yang Guo

Adjust GKE spec to validate images with kernel version 4.10+

parent 33f873db
...@@ -135,6 +135,7 @@ go_test( ...@@ -135,6 +135,7 @@ go_test(
"//test/e2e_node/services:go_default_library", "//test/e2e_node/services:go_default_library",
"//test/e2e_node/system:go_default_library", "//test/e2e_node/system:go_default_library",
"//test/utils/image:go_default_library", "//test/utils/image:go_default_library",
"//vendor/github.com/blang/semver:go_default_library",
"//vendor/github.com/coreos/go-systemd/util:go_default_library", "//vendor/github.com/coreos/go-systemd/util:go_default_library",
"//vendor/github.com/davecgh/go-spew/spew:go_default_library", "//vendor/github.com/davecgh/go-spew/spew:go_default_library",
"//vendor/github.com/golang/glog:go_default_library", "//vendor/github.com/golang/glog:go_default_library",
......
...@@ -28,6 +28,7 @@ import ( ...@@ -28,6 +28,7 @@ import (
"k8s.io/kubernetes/test/e2e/framework" "k8s.io/kubernetes/test/e2e/framework"
"github.com/blang/semver"
. "github.com/onsi/ginkgo" . "github.com/onsi/ginkgo"
) )
...@@ -122,6 +123,18 @@ func checkDockerConfig() error { ...@@ -122,6 +123,18 @@ func checkDockerConfig() error {
} }
missing = map[string]bool{} missing = map[string]bool{}
) )
// Whitelists CONFIG_DEVPTS_MULTIPLE_INSTANCES (meaning allowing it to be
// absent) if the kernel version is >= 4.8, because this option has been
// removed from the 4.8 kernel.
kernelVersion, err := getKernelVersion()
if err != nil {
return err
}
if kernelVersion.GTE(semver.MustParse("4.8.0")) {
whitelist["CONFIG_DEVPTS_MULTIPLE_INSTANCES"] = true
}
for _, bin := range bins { for _, bin := range bins {
if _, err := os.Stat(bin); os.IsNotExist(err) { if _, err := os.Stat(bin); os.IsNotExist(err) {
continue continue
...@@ -400,3 +413,18 @@ func getCmdToProcessMap() (map[string][]process, error) { ...@@ -400,3 +413,18 @@ func getCmdToProcessMap() (map[string][]process, error) {
} }
return result, nil return result, nil
} }
// getKernelVersion returns the kernel version in the semantic version format.
func getKernelVersion() (*semver.Version, error) {
output, err := runCommand("uname", "-r")
if err != nil {
return nil, err
}
// An example 'output' could be "4.13.0-1001-gke".
v := strings.TrimSpace(strings.Split(output, "-")[0])
kernelVersion, err := semver.Make(v)
if err != nil {
return nil, fmt.Errorf("failed to convert %q to semantic version: %s", v, err)
}
return &kernelVersion, nil
}
...@@ -5,7 +5,9 @@ os: Linux ...@@ -5,7 +5,9 @@ os: Linux
kernelSpec: kernelSpec:
versions: versions:
# GKE requires kernel version 4.4+. # GKE requires kernel version 4.4+.
- 4\.[4-9].* - '4\.[4-9].*'
- '4\.[1-9][0-9].*'
- '[5-9].*'
# Required kernel configurations -- the configuration must be set to "y" or # Required kernel configurations -- the configuration must be set to "y" or
# "m". # "m".
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment