Skip to content

K
k3s
Unverified Commit 8e7e2264 authored by k8s-ci-robot's avatar k8s-ci-robot Committed by GitHub
Browse files
Options

Merge pull request #69636 from p0lyn0mial/sample_controller_factory_start

fixes the way the informers are started in sample controller pkg
parents 04d39490 e55ca64d
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 2 deletions
staging/src/k8s.io/sample-controller/main.go
View file @ 8e7e2264
......@@ -65,8 +65,10 @@ func main() {
kubeInformerFactory.Apps().V1().Deployments(),
exampleInformerFactory.Samplecontroller().V1alpha1().Foos())
go kubeInformerFactory.Start(stopCh)
go exampleInformerFactory.Start(stopCh)
// notice that there is no need to run Start methods in a separate goroutine. (i.e. go kubeInformerFactory.Start(stopCh)
// Start method is non-blocking and runs all registered informers in a dedicated goroutine.
kubeInformerFactory.Start(stopCh)
exampleInformerFactory.Start(stopCh)
if err = controller.Run(2, stopCh); err != nil {
glog.Fatalf("Error running controller: %s", err.Error())
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment