Merge pull request #50823 from zjj2wry/set-image

Automatic merge from submit-queue (batch tested with PRs 50277, 50823, 50376, 50867) fix issue(#50821)Add image check, if image not changed, transform false **What this PR does / why we need it**: closes #50821 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```

Merge pull request #50823 from zjj2wry/set-image
89abb48f · Kubernetes Submit Queue · GitHub · a4f6ae44 · a8c68d92 · 89abb48f
Commit 89abb48f authored Aug 17, 2017 by Kubernetes Submit Queue Committed by GitHub Aug 17, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 3 deletions

test-cmd-util.sh hack/make-rules/test-cmd-util.sh +4 -0

set_image.go pkg/kubectl/cmd/set/set_image.go +5 -3

No files found.
--- a/hack/make-rules/test-cmd-util.sh
+++ b/hack/make-rules/test-cmd-util.sh
@@ -2848,6 +2848,10 @@ run_deployment_tests() {
  kubectl set image deployment nginx-deployment "*"="${IMAGE_DEPLOYMENT_R1}" "${kube_flags[@]}"
  kube::test::get_object_assert deployment "{{range.items}}{{$deployment_image_field}}:{{end}}" "${IMAGE_DEPLOYMENT_R1}:"
  kube::test::get_object_assert deployment "{{range.items}}{{$deployment_second_image_field}}:{{end}}" "${IMAGE_DEPLOYMENT_R1}:"
+  # Set image of all containners of the deployment again when image not change
+  kubectl set image deployment nginx-deployment "*"="${IMAGE_DEPLOYMENT_R1}" "${kube_flags[@]}"
+  kube::test::get_object_assert deployment "{{range.items}}{{$deployment_image_field}}:{{end}}" "${IMAGE_DEPLOYMENT_R1}:"
+  kube::test::get_object_assert deployment "{{range.items}}{{$deployment_second_image_field}}:{{end}}" "${IMAGE_DEPLOYMENT_R1}:"
  # Clean up
  kubectl delete deployment nginx-deployment "${kube_flags[@]}"

--- a/pkg/kubectl/cmd/set/set_image.go
+++ b/pkg/kubectl/cmd/set/set_image.go
@@ -196,9 +196,11 @@ func (o *ImageOptions) Run() error {
 								continue
 							}
 						}
-						spec.Containers[i].Image = resolved
+						if spec.Containers[i].Image != resolved {
-						// Perform updates
+							spec.Containers[i].Image = resolved
-						transformed = true
+							// Perform updates
+							transformed = true
+						}
 					}
 				}
 				// Add a new container if not found