Unverified Commit 8743a0e3 authored by Kubernetes Prow Robot's avatar Kubernetes Prow Robot Committed by GitHub

Merge pull request #72033 from galexrt/more_logging_in_rbd_provisioner

rbd: log error when unable to get Secret
parents df77b729 f9e7ba07
...@@ -1077,8 +1077,8 @@ func getVolumeAccessModes(spec *volume.Spec) ([]v1.PersistentVolumeAccessMode, e ...@@ -1077,8 +1077,8 @@ func getVolumeAccessModes(spec *volume.Spec) ([]v1.PersistentVolumeAccessMode, e
func parsePodSecret(pod *v1.Pod, secretName string, kubeClient clientset.Interface) (string, error) { func parsePodSecret(pod *v1.Pod, secretName string, kubeClient clientset.Interface) (string, error) {
secret, err := volutil.GetSecretForPod(pod, secretName, kubeClient) secret, err := volutil.GetSecretForPod(pod, secretName, kubeClient)
if err != nil { if err != nil {
klog.Errorf("failed to get secret from [%q/%q]", pod.Namespace, secretName) klog.Errorf("failed to get secret from [%q/%q]: %+v", pod.Namespace, secretName, err)
return "", fmt.Errorf("failed to get secret from [%q/%q]", pod.Namespace, secretName) return "", fmt.Errorf("failed to get secret from [%q/%q]: %+v", pod.Namespace, secretName, err)
} }
return parseSecretMap(secret) return parseSecretMap(secret)
} }
...@@ -1086,8 +1086,8 @@ func parsePodSecret(pod *v1.Pod, secretName string, kubeClient clientset.Interfa ...@@ -1086,8 +1086,8 @@ func parsePodSecret(pod *v1.Pod, secretName string, kubeClient clientset.Interfa
func parsePVSecret(namespace, secretName string, kubeClient clientset.Interface) (string, error) { func parsePVSecret(namespace, secretName string, kubeClient clientset.Interface) (string, error) {
secret, err := volutil.GetSecretForPV(namespace, secretName, rbdPluginName, kubeClient) secret, err := volutil.GetSecretForPV(namespace, secretName, rbdPluginName, kubeClient)
if err != nil { if err != nil {
klog.Errorf("failed to get secret from [%q/%q]", namespace, secretName) klog.Errorf("failed to get secret from [%q/%q]: %+v", namespace, secretName, err)
return "", fmt.Errorf("failed to get secret from [%q/%q]", namespace, secretName) return "", fmt.Errorf("failed to get secret from [%q/%q]: %+v", namespace, secretName, err)
} }
return parseSecretMap(secret) return parseSecretMap(secret)
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment