Merge pull request #48584 from yiqinguo/yiqinguo_eventtype

Automatic merge from submit-queue (batch tested with PRs 49444, 47864, 48584, 49395, 49118) Move event type Change SandboxChanged to a constant and move to the event package below. **Release note**: ```release-note NONE ```

Merge pull request #48584 from yiqinguo/yiqinguo_eventtype
86cc83c3 · Kubernetes Submit Queue · GitHub · 633079eb · 5417a1d5 · 86cc83c3
Commit 86cc83c3 authored Jul 24, 2017 by Kubernetes Submit Queue Committed by GitHub Jul 24, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

event.go pkg/kubelet/events/event.go +1 -0

kuberuntime_manager.go pkg/kubelet/kuberuntime/kuberuntime_manager.go +1 -1

No files found.
--- a/pkg/kubelet/events/event.go
+++ b/pkg/kubelet/events/event.go
@@ -62,6 +62,7 @@ const (
 	FailedNodeAllocatableEnforcement     = "FailedNodeAllocatableEnforcement"
 	SuccessfulNodeAllocatableEnforcement = "NodeAllocatableEnforced"
 	UnsupportedMountOption               = "UnsupportedMountOption"
+	SandboxChanged                       = "SandboxChanged"
 	// Image manager event reason list
 	InvalidDiskCapacity = "InvalidDiskCapacity"

--- a/pkg/kubelet/kuberuntime/kuberuntime_manager.go
+++ b/pkg/kubelet/kuberuntime/kuberuntime_manager.go
@@ -552,7 +552,7 @@ func (m *kubeGenericRuntimeManager) SyncPod(pod *v1.Pod, _ v1.PodStatus, podStat
 			glog.Errorf("Couldn't make a ref to pod %q: '%v'", format.Pod(pod), err)
 		}
 		if podContainerChanges.SandboxID != "" {
-			m.recorder.Eventf(ref, v1.EventTypeNormal, "SandboxChanged", "Pod sandbox changed, it will be killed and re-created.")
+			m.recorder.Eventf(ref, v1.EventTypeNormal, events.SandboxChanged, "Pod sandbox changed, it will be killed and re-created.")
 		} else {
 			glog.V(4).Infof("SyncPod received new pod %q, will create a new sandbox for it", format.Pod(pod))
 		}