Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
86025129
Commit
86025129
authored
Jun 12, 2015
by
Manan Saraf
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed pointers bug in PATCH verb in the API
parent
965711e8
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
75 additions
and
0 deletions
+75
-0
patch.go
pkg/util/strategicpatch/patch.go
+5
-0
patch_test.go
pkg/util/strategicpatch/patch_test.go
+70
-0
No files found.
pkg/util/strategicpatch/patch.go
View file @
86025129
...
...
@@ -100,6 +100,11 @@ func mergeMap(original, patch map[string]interface{}, t reflect.Type) (map[strin
original
[
k
]
=
patchV
continue
}
// If the data type is a pointer, resolve the element.
if
t
.
Kind
()
==
reflect
.
Ptr
{
t
=
t
.
Elem
()
}
// If they're both maps or lists, recurse into the value.
// First find the fieldPatchStrategy and fieldPatchMergeKey.
fieldType
,
fieldPatchStrategy
,
fieldPatchMergeKey
,
err
:=
forkedjson
.
LookupPatchMetadata
(
t
,
k
)
...
...
pkg/util/strategicpatch/patch_test.go
View file @
86025129
...
...
@@ -51,6 +51,7 @@ type MergeItem struct {
NonMergingList
[]
MergeItem
MergingIntList
[]
int
`patchStrategy:"merge"`
NonMergingIntList
[]
int
MergeItemPtr
*
MergeItem
`patchStrategy:"merge" patchMergeKey:"name"`
SimpleMap
map
[
string
]
string
}
...
...
@@ -232,6 +233,41 @@ strategicMergePatchCases:
- $patch: replace
result:
mergingList: []
- description: add new field inside pointers
original:
mergeItemPtr:
- name: 1
patch:
mergeItemPtr:
- name: 2
result:
mergeItemPtr:
- name: 1
- name: 2
- description: update nested pointers
original:
mergeItemPtr:
- name: 1
mergeItemPtr:
- name: 1
- name: 2
value: 2
- name: 2
patch:
mergeItemPtr:
- name: 1
mergeItemPtr:
- name: 1
value: 1
result:
mergeItemPtr:
- name: 1
mergeItemPtr:
- name: 1
value: 1
- name: 2
value: 2
- name: 2
sortMergeListTestCases:
- description: sort one list of maps
original:
...
...
@@ -351,6 +387,40 @@ sortMergeListTestCases:
- 1
- 2
- 3
- description: sort nested pointers of ints
original:
mergeItemPtr:
- name: 2
mergingIntList:
- 1
- 3
- 2
- name: 1
mergingIntList:
- 2
- 1
sorted:
mergeItemPtr:
- name: 1
mergingIntList:
- 1
- 2
- name: 2
mergingIntList:
- 1
- 2
- 3
- description: sort one pointer of maps
original:
mergeItemPtr:
- name: 1
- name: 3
- name: 2
sorted:
mergeItemPtr:
- name: 1
- name: 2
- name: 3
`
)
func
TestStrategicMergePatch
(
t
*
testing
.
T
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment