Skip to content

K
k3s
Commit 8448b60f authored by Clayton Coleman's avatar Clayton Coleman
Browse files
Options

Kubelet server was not returning a 500 on errors writing logs

Writing 200 first masks the second error. 200 is defaulted by the Go http stack automatically.
parent 4f559b3a
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 1 deletion
pkg/kubelet/server/server.go
View file @ 8448b60f
......@@ -440,7 +440,6 @@ func (s *Server) getContainerLogs(request *restful.Request, response *restful.Re
fw = limitwriter.New(fw, *logOptions.LimitBytes)
}
response.Header().Set("Transfer-Encoding", "chunked")
response.WriteHeader(http.StatusOK)
if err := s.host.GetKubeletContainerLogs(kubecontainer.GetPodFullName(pod), containerName, logOptions, fw, fw); err != nil {
if err != limitwriter.ErrMaximumWrite {
response.WriteError(http.StatusInternalServerError, err)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment