A optimization for “RegisterCustomFitPredicate” function, avoiding redundancy

In RegisterCustomFitPredicate, when policy.Argument is nil and fitPredicateMap has the policy.Name, it can return the policy.Name directly. Subsequent operations are redundant.

A optimization for “RegisterCustomFitPredicate” function, avoiding redundancy
82009eb5 · PingWang · 4513b7c2 · 82009eb5
Commit 82009eb5 authored May 13, 2016 by PingWang
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 0 deletions

plugins.go plugin/pkg/scheduler/factory/plugins.go +1 -0

No files found.
--- a/plugin/pkg/scheduler/factory/plugins.go
+++ b/plugin/pkg/scheduler/factory/plugins.go
@@ -121,6 +121,7 @@ func RegisterCustomFitPredicate(policy schedulerapi.PredicatePolicy) string {
 	} else if predicateFactory, ok = fitPredicateMap[policy.Name]; ok {
 		// checking to see if a pre-defined predicate is requested
 		glog.V(2).Infof("Predicate type %s already registered, reusing.", policy.Name)
+		return policy.Name
 	}

 	if predicateFactory == nil {