Merge pull request #53048 from kubermatic/log-healthz-check-fail

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Log error when a healthz check fails **What this PR does / why we need it**: Currently we only tell a user that a healthz check failed but we don't display the explicit error of the failed check. This is fine, but we should log the error to make debugging easier. ```release-note Log error of failed healthz check ```

Merge pull request #53048 from kubermatic/log-healthz-check-fail
816f2f46 · Kubernetes Submit Queue · GitHub · 618b705a · 1bcfe909 · 816f2f46
Unverified Commit 816f2f46 authored Nov 01, 2017 by Kubernetes Submit Queue Committed by GitHub Nov 01, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

healthz.go staging/src/k8s.io/apiserver/pkg/server/healthz/healthz.go +2 -1

No files found.
--- a/staging/src/k8s.io/apiserver/pkg/server/healthz/healthz.go
+++ b/staging/src/k8s.io/apiserver/pkg/server/healthz/healthz.go
@@ -106,9 +106,10 @@ func handleRootHealthz(checks ...HealthzChecker) http.HandlerFunc {
 		failed := false
 		var verboseOut bytes.Buffer
 		for _, check := range checks {
-			if check.Check(r) != nil {
+			if err := check.Check(r); err != nil {
 				// don't include the error since this endpoint is public.  If someone wants more detail
 				// they should have explicit permission to the detailed checks.
+				glog.V(6).Infof("healthz check %v failed: %v", check.Name(), err)
 				fmt.Fprintf(&verboseOut, "[-]%v failed: reason withheld\n", check.Name())
 				failed = true
 			} else {