Skip to content

K
k3s
Unverified Commit 800615ab authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #67485 from linyouchong/pr-0816

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove incorrect comment **What this PR does / why we need it**: These code did not Update the revisions labels, the comment is incorrect ``` // Update the revisions name and labels clone.Name = ControllerRevisionName(parent.GetName(), hash) ns := parent.GetNamespace() created, err := rh.client.AppsV1().ControllerRevisions(ns).Create(clone) ``` **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: NONE **Release note**: ``` NONE ``` /kind cleanup /release-note-none /sig apps
parents b72e61ed b4c27a15
Hide whitespace changes
Inline Side-by-side
Showing with 1 addition and 1 deletion
pkg/controller/history/controller_history.go
View file @ 800615ab
......@@ -248,7 +248,7 @@ func (rh *realHistory) CreateControllerRevision(parent metav1.Object, revision *
// Continue to attempt to create the revision updating the name with a new hash on each iteration
for {
hash := HashControllerRevision(revision, collisionCount)
// Update the revisions name and labels
// Update the revisions name
clone.Name = ControllerRevisionName(parent.GetName(), hash)
ns := parent.GetNamespace()
created, err := rh.client.AppsV1().ControllerRevisions(ns).Create(clone)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment