Merge pull request #38440 from justinsb/conversion_gen_safe_at_some_speeds

Automatic merge from submit-queue conversion-gen: add --skip-unsafe flag We should expose the SkipUnsafe option, for legacy compatability, so that conversion-go can be used in other projects, and for platforms where unsafe is not available. Make unsafe code generation the default though, and have the help text hint that the resulting code is sub-optimal.

Merge pull request #38440 from justinsb/conversion_gen_safe_at_some_speeds
7e1cacaa · Kubernetes Submit Queue · GitHub · 01b9d496 · dd351db7 · 7e1cacaa
Commit 7e1cacaa authored Dec 18, 2016 by Kubernetes Submit Queue Committed by GitHub Dec 18, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

main.go cmd/libs/go2idl/conversion-gen/main.go +2 -0

known-flags.txt hack/verify-flags/known-flags.txt +1 -0

No files found.
--- a/cmd/libs/go2idl/conversion-gen/main.go
+++ b/cmd/libs/go2idl/conversion-gen/main.go
@@ -64,6 +64,8 @@ func main() {
 	}
 	pflag.CommandLine.StringSliceVar(&customArgs.ExtraPeerDirs, "extra-peer-dirs", customArgs.ExtraPeerDirs,
 		"Comma-separated list of import paths which are considered, after tag-specified peers, for conversions.")
+	pflag.CommandLine.BoolVar(&customArgs.SkipUnsafe, "skip-unsafe", customArgs.SkipUnsafe,
+		"If true, will not generate code using unsafe pointer conversions; resulting code may be slower.")
 	arguments.CustomArgs = customArgs
 	// Run it.

--- a/hack/verify-flags/known-flags.txt
+++ b/hack/verify-flags/known-flags.txt
@@ -568,6 +568,7 @@ since-time
 skip-generated-rewrite
 skip-munges
 skip-preflight-checks
+skip-unsafe
 sort-by
 source-file
 ssh-env