Unverified Commit 7da6b421 authored by Kubernetes Prow Robot's avatar Kubernetes Prow Robot Committed by GitHub

Merge pull request #72786 from caesarxuchao/72364-minor-followup

followup of #72364, slightly improve the comment
parents d1031b18 e2812ce3
...@@ -864,7 +864,12 @@ func TestGarbageCollectorSync(t *testing.T) { ...@@ -864,7 +864,12 @@ func TestGarbageCollectorSync(t *testing.T) {
// gc.resyncMonitors() // gc.resyncMonitors()
// controller.WaitForCacheSync() loops with `syncedPollPeriod` (hardcoded to 100ms), until either its stop channel is closed after `period`, or all caches synced. // controller.WaitForCacheSync() loops with `syncedPollPeriod` (hardcoded to 100ms), until either its stop channel is closed after `period`, or all caches synced.
// //
// Setting the period to 200ms allows the WaitForCacheSync() to check for cache sync ~2 times in every wait.PollImmediateUntil() loop. // Setting the period to 200ms allows the WaitForCacheSync() to check
// for cache sync ~2 times in every wait.PollImmediateUntil() loop.
//
// The 1s sleep in the test allows GetDelableResources and
// gc.resyncMoitors to run ~5 times to ensure the changes to the
// fakeDiscoveryClient are picked up.
go gc.Sync(fakeDiscoveryClient, 200*time.Millisecond, stopCh) go gc.Sync(fakeDiscoveryClient, 200*time.Millisecond, stopCh)
// Wait until the sync discovers the initial resources // Wait until the sync discovers the initial resources
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment