Merge pull request #51081 from diegs/typo

Automatic merge from submit-queue (batch tested with PRs 51081, 52725). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. daemon_controller: fix typo. **What this PR does / why we need it**: I found a small typo while implementing #48841. With the existing code, some edge cases might lead to the wrong pods being deleted. **Release note**: ```release-note NONE ```

Merge pull request #51081 from diegs/typo
7ca9ec79 · Kubernetes Submit Queue · GitHub · a238fbd2 · 9baaeba4 · 7ca9ec79
Commit 7ca9ec79 authored Sep 19, 2017 by Kubernetes Submit Queue Committed by GitHub Sep 19, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

daemon_controller.go pkg/controller/daemon/daemon_controller.go +1 -1

No files found.
--- a/pkg/controller/daemon/daemon_controller.go
+++ b/pkg/controller/daemon/daemon_controller.go
@@ -855,7 +855,7 @@ func (dsc *DaemonSetsController) manage(ds *extensions.DaemonSet, hash string) e
 			if len(daemonPodsRunning) > 1 {
 				sort.Sort(podByCreationTimestamp(daemonPodsRunning))
 				for i := 1; i < len(daemonPodsRunning); i++ {
-					podsToDelete = append(podsToDelete, daemonPods[i].Name)
+					podsToDelete = append(podsToDelete, daemonPodsRunning[i].Name)
 				}
 			}
 		case !shouldContinueRunning && exists: