Merge pull request #52873 from ixdy/bazel-cleanup

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. bazel: build/test almost everything **What this PR does / why we need it**: Miscellaneous cleanups and bug fixes. The main motivating idea here was to make `bazel build //...` and `bazel test //...` mostly work. (There's a few reasons these still don't work, but we're a lot closer.) **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /assign @BenTheElder @mikedanese @spxtr

Merge pull request #52873 from ixdy/bazel-cleanup
7c9e614c · Kubernetes Submit Queue · GitHub · f67e127a · 6bf7fc35 · 7c9e614c
Commit 7c9e614c authored Sep 24, 2017 by Kubernetes Submit Queue Committed by GitHub Sep 24, 2017
60 changed files
--- a/build/root/BUILD.root
+++ b/build/root/BUILD.root
@@ -5,7 +5,7 @@
 package(default_visibility = ["//visibility:public"])
-load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_prefix")
+load("@io_bazel_rules_go//go:def.bzl", "go_prefix")
 load("@io_kubernetes_build//defs:build.bzl", "gcs_upload")
 go_prefix("k8s.io/kubernetes")
@@ -29,6 +29,7 @@ gcs_upload(
        "//build/release-tars:release-tars-and-hashes",
        "//cluster/gce:gcs-release-artifacts-and-hashes",
    ],
+    tags = ["manual"],
    upload_paths = {
        "//:_binary-artifacts-and-hashes": "bin/linux/amd64",
        "//build/release-tars:release-tars-and-hashes": "",
@@ -80,26 +81,3 @@ genrule(
    cmd = "grep ^STABLE_BUILD_SCM_REVISION bazel-out/stable-status.txt | awk '{print $$2}' >$@",
    stamp = 1,
 )
-go_library(
-    name = "go_default_library",
-    srcs = [
-        "generated.pb.go",
-        "types.go",
-    ],
-    deps = [
-        "//vendor/github.com/gogo/protobuf/proto:go_default_library",
-        "//vendor/github.com/gogo/protobuf/sortkeys:go_default_library",
-        "//vendor/k8s.io/apimachinery/pkg/api/resource:go_default_library",
-        "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
-        "//vendor/k8s.io/apimachinery/pkg/runtime:go_default_library",
-        "//vendor/k8s.io/apimachinery/pkg/types:go_default_library",
-        "//vendor/k8s.io/apimachinery/pkg/util/intstr:go_default_library",
-    ],
-)
-filegroup(
-    name = "go_default_library_protos",
-    srcs = ["generated.proto"],
-    visibility = ["//visibility:public"],
-)
--- a/build/root/Makefile
+++ b/build/root/Makefile
@@ -521,8 +521,9 @@ endef
 bazel-build:
 	@echo "$$BAZEL_BUILD_HELP_INFO"
 else
+# Some things in vendor don't build due to empty target lists for cross-platform rules.
 bazel-build:
-	bazel build //cmd/... //hack/... //pkg/... //federation/... //plugin/... //third_party/... //examples/... //test/... //vendor/k8s.io/...
+	bazel build -- //... -//vendor/...
 endif
@@ -536,8 +537,15 @@ endef
 bazel-test:
 	@echo "$$BAZEL_TEST_HELP_INFO"
 else
+# //hack:verify-all is a manual target.
+# We don't want to build any of the release artifacts when running tests.
+# Some things in vendor don't build due to empty target lists for cross-platform rules.
 bazel-test:
-	bazel test --test_tag_filters=-integration --flaky_test_attempts=3 //cmd/... //pkg/... //federation/... //plugin/... //third_party/... //hack/... //hack:verify-all //vendor/k8s.io/...
+	bazel test --build_tag_filters=-e2e,-integration --test_tag_filters=-e2e,-integration --flaky_test_attempts=3 -- \
+	  //... \
+	  //hack:verify-all \
+	  -//build/... \
+	  -//vendor/...
 endif
 ifeq ($(PRINT_HELP),y)

--- a/cmd/kubeadm/app/phases/addons/dns/BUILD
+++ b/cmd/kubeadm/app/phases/addons/dns/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -15,7 +13,6 @@ go_test(
        "versions_test.go",
    ],
    library = ":go_default_library",
-    tags = ["automanaged"],
    deps = [
        "//cmd/kubeadm/app/util:go_default_library",
        "//pkg/api:go_default_library",
@@ -34,7 +31,6 @@ go_library(
        "manifests.go",
        "versions.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//cmd/kubeadm/app/apis/kubeadm:go_default_library",
        "//cmd/kubeadm/app/constants:go_default_library",

--- a/cmd/kubeadm/app/phases/addons/proxy/BUILD
+++ b/cmd/kubeadm/app/phases/addons/proxy/BUILD
@@ -10,7 +10,6 @@ go_test(
    name = "go_default_test",
    srcs = ["proxy_test.go"],
    library = ":go_default_library",
-    tags = ["automanaged"],
    deps = [
        "//cmd/kubeadm/app/util:go_default_library",
        "//pkg/api:go_default_library",

--- a/cmd/kubeadm/app/phases/etcd/BUILD
+++ b/cmd/kubeadm/app/phases/etcd/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -12,7 +10,6 @@ go_test(
    name = "go_default_test",
    srcs = ["local_test.go"],
    library = ":go_default_library",
-    tags = ["automanaged"],
    deps = [
        "//cmd/kubeadm/app/apis/kubeadm:go_default_library",
        "//cmd/kubeadm/app/constants:go_default_library",
@@ -23,7 +20,6 @@ go_test(
 go_library(
    name = "go_default_library",
    srcs = ["local.go"],
-    tags = ["automanaged"],
    deps = [
        "//cmd/kubeadm/app/apis/kubeadm:go_default_library",
        "//cmd/kubeadm/app/constants:go_default_library",

--- a/cmd/kubeadm/app/util/staticpod/BUILD
+++ b/cmd/kubeadm/app/util/staticpod/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -12,7 +10,6 @@ go_test(
    name = "go_default_test",
    srcs = ["utils_test.go"],
    library = ":go_default_library",
-    tags = ["automanaged"],
    deps = [
        "//vendor/k8s.io/api/core/v1:go_default_library",
        "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
@@ -23,7 +20,6 @@ go_test(
 go_library(
    name = "go_default_library",
    srcs = ["utils.go"],
-    tags = ["automanaged"],
    deps = [
        "//cmd/kubeadm/app/constants:go_default_library",
        "//pkg/kubelet/types:go_default_library",

--- a/examples/BUILD
+++ b/examples/BUILD
@@ -17,13 +17,6 @@ filegroup(
    ],
 )
-filegroup(
-    name = "sources",
-    srcs = glob([
-        "**/*",
-    ]),
-)
 go_library(
    name = "go_default_library",
    srcs = ["doc.go"],
@@ -32,6 +25,7 @@ go_library(
 go_test(
    name = "go_default_xtest",
    srcs = ["examples_test.go"],
+    tags = ["manual"],  # this test is broken and examples in-tree is deprecated
    deps = [
        "//pkg/api:go_default_library",
        "//pkg/api/testapi:go_default_library",

--- a/pkg/api/v1/validation/BUILD
+++ b/pkg/api/v1/validation/BUILD
@@ -38,7 +38,6 @@ go_test(
    name = "go_default_test",
    srcs = ["validation_test.go"],
    library = ":go_default_library",
-    tags = ["automanaged"],
    deps = [
        "//vendor/k8s.io/api/core/v1:go_default_library",
        "//vendor/k8s.io/apimachinery/pkg/api/resource:go_default_library",

--- a/pkg/apis/batch/v1beta1/BUILD
+++ b/pkg/apis/batch/v1beta1/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -18,7 +16,6 @@ go_library(
        "zz_generated.conversion.go",
        "zz_generated.defaults.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//pkg/api:go_default_library",
        "//pkg/api/v1:go_default_library",
@@ -36,7 +33,6 @@ go_library(
 go_test(
    name = "go_default_xtest",
    srcs = ["defaults_test.go"],
-    tags = ["automanaged"],
    deps = [
        ":go_default_library",
        "//pkg/api:go_default_library",

--- a/pkg/capabilities/BUILD
+++ b/pkg/capabilities/BUILD
@@ -18,7 +18,6 @@ go_test(
    name = "go_default_test",
    srcs = ["capabilities_test.go"],
    library = ":go_default_library",
-    tags = ["automanaged"],
 )
 filegroup(

--- a/pkg/controller/cloud/BUILD
+++ b/pkg/controller/cloud/BUILD
@@ -12,7 +12,6 @@ go_library(
        "node_controller.go",
        "pvlcontroller.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//pkg/api/v1/node:go_default_library",
        "//pkg/cloudprovider:go_default_library",

--- a/pkg/controller/volume/expand/BUILD
+++ b/pkg/controller/volume/expand/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -14,7 +12,6 @@ go_library(
        "pvc_populator.go",
        "sync_volume_resize.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//pkg/cloudprovider:go_default_library",
        "//pkg/controller:go_default_library",

--- a/pkg/controller/volume/expand/cache/BUILD
+++ b/pkg/controller/volume/expand/cache/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -11,7 +9,6 @@ load(
 go_library(
    name = "go_default_library",
    srcs = ["volume_resize_map.go"],
-    tags = ["automanaged"],
    deps = [
        "//pkg/controller/volume/expand/util:go_default_library",
        "//pkg/util/strings:go_default_library",

--- a/pkg/kubeapiserver/admission/util/BUILD
+++ b/pkg/kubeapiserver/admission/util/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -10,7 +8,6 @@ load(
 go_library(
    name = "go_default_library",
    srcs = ["initializer.go"],
-    tags = ["automanaged"],
    deps = [
        "//vendor/k8s.io/apimachinery/pkg/api/meta:go_default_library",
        "//vendor/k8s.io/apimachinery/pkg/util/initialization:go_default_library",

--- a/pkg/kubectl/apps/BUILD
+++ b/pkg/kubectl/apps/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -11,7 +9,6 @@ load(
 go_library(
    name = "go_default_library",
    srcs = ["kind_visitor.go"],
-    tags = ["automanaged"],
    deps = ["//vendor/k8s.io/apimachinery/pkg/runtime/schema:go_default_library"],
 )

--- a/pkg/kubectl/cmd/util/openapi/testing/BUILD
+++ b/pkg/kubectl/cmd/util/openapi/testing/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -10,7 +8,6 @@ load(
 go_library(
    name = "go_default_library",
    srcs = ["openapi.go"],
-    tags = ["automanaged"],
    deps = [
        "//vendor/github.com/googleapis/gnostic/OpenAPIv2:go_default_library",
        "//vendor/github.com/googleapis/gnostic/compiler:go_default_library",

--- a/pkg/kubectl/cmd/util/openapi/validation/BUILD
+++ b/pkg/kubectl/cmd/util/openapi/validation/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -15,7 +13,6 @@ go_library(
        "types.go",
        "validation.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//pkg/api:go_default_library",
        "//pkg/api/util:go_default_library",
@@ -34,7 +31,6 @@ go_test(
        "validation_test.go",
    ],
    data = ["//api/openapi-spec:swagger-spec"],
-    tags = ["automanaged"],
    deps = [
        ":go_default_library",
        "//pkg/api/testapi:go_default_library",

--- a/pkg/kubectl/util/hash/BUILD
+++ b/pkg/kubectl/util/hash/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -12,14 +10,12 @@ go_test(
    name = "go_default_test",
    srcs = ["hash_test.go"],
    library = ":go_default_library",
-    tags = ["automanaged"],
    deps = ["//pkg/api:go_default_library"],
 )
 go_library(
    name = "go_default_library",
    srcs = ["hash.go"],
-    tags = ["automanaged"],
    deps = ["//pkg/api:go_default_library"],
 )

--- a/pkg/kubectl/validation/BUILD
+++ b/pkg/kubectl/validation/BUILD
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -34,7 +32,6 @@ go_test(
        "//api/swagger-spec",
    ],
    library = ":go_default_library",
-    tags = ["automanaged"],
    deps = [
        "//pkg/api:go_default_library",
        "//pkg/api/testapi:go_default_library",
@@ -51,7 +48,6 @@ go_test(
 go_library(
    name = "go_default_library",
    srcs = ["schema.go"],
-    tags = ["automanaged"],
    visibility = ["//build/visible_to:pkg_kubectl_validation_CONSUMERS"],
    deps = [
        "//pkg/api/util:go_default_library",

--- a/pkg/kubelet/apis/deviceplugin/v1alpha1/BUILD
+++ b/pkg/kubelet/apis/deviceplugin/v1alpha1/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -13,7 +11,6 @@ go_library(
        "api.pb.go",
        "constants.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//vendor/github.com/gogo/protobuf/gogoproto:go_default_library",
        "//vendor/github.com/gogo/protobuf/proto:go_default_library",

--- a/pkg/kubelet/apis/kubeletconfig/BUILD
+++ b/pkg/kubelet/apis/kubeletconfig/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -15,7 +13,6 @@ go_library(
        "types.go",
        "zz_generated.deepcopy.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//pkg/api:go_default_library",
        "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",

--- a/pkg/kubelet/apis/kubeletconfig/v1alpha1/BUILD
+++ b/pkg/kubelet/apis/kubeletconfig/v1alpha1/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -18,7 +16,6 @@ go_library(
        "zz_generated.deepcopy.go",
        "zz_generated.defaults.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//pkg/api:go_default_library",
        "//pkg/kubelet/apis/kubeletconfig:go_default_library",

--- a/pkg/kubelet/apis/kubeletconfig/validation/BUILD
+++ b/pkg/kubelet/apis/kubeletconfig/validation/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -11,7 +9,6 @@ load(
 go_library(
    name = "go_default_library",
    srcs = ["validation.go"],
-    tags = ["automanaged"],
    deps = [
        "//pkg/kubelet/apis/kubeletconfig:go_default_library",
        "//pkg/kubelet/cm:go_default_library",

--- a/pkg/kubelet/deviceplugin/BUILD
+++ b/pkg/kubelet/deviceplugin/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -17,7 +15,6 @@ go_library(
        "types.go",
        "utils.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//pkg/api/v1/helper:go_default_library",
        "//pkg/kubelet/apis/deviceplugin/v1alpha1:go_default_library",

--- a/pkg/proxy/ipvs/BUILD
+++ b/pkg/proxy/ipvs/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -17,7 +15,6 @@ go_test(
        "//conditions:default": [],
    }),
    library = ":go_default_library",
-    tags = ["automanaged"],
    deps = select({
        "@io_bazel_rules_go//go/platform:linux_amd64": [
            "//pkg/api:go_default_library",
@@ -42,7 +39,6 @@ go_test(
 go_library(
    name = "go_default_library",
    srcs = ["proxier.go"],
-    tags = ["automanaged"],
    deps = [
        "//pkg/api:go_default_library",
        "//pkg/api/helper:go_default_library",

--- a/pkg/util/ipvs/BUILD
+++ b/pkg/util/ipvs/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -19,7 +17,6 @@ go_test(
        "//conditions:default": [],
    }),
    library = ":go_default_library",
-    tags = ["automanaged"],
    deps = select({
        "@io_bazel_rules_go//go/platform:linux_amd64": [
            "//vendor/github.com/docker/libnetwork/ipvs:go_default_library",
@@ -42,7 +39,6 @@ go_library(
        ],
        "//conditions:default": [],
    }),
-    tags = ["automanaged"],
    deps = [
        "//vendor/k8s.io/utils/exec:go_default_library",
    ] + select({

--- a/pkg/util/ipvs/testing/BUILD
+++ b/pkg/util/ipvs/testing/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -10,7 +8,6 @@ load(
 go_library(
    name = "go_default_library",
    srcs = ["fake.go"],
-    tags = ["automanaged"],
    deps = ["//pkg/util/ipvs:go_default_library"],
 )

--- a/plugin/pkg/admission/eventratelimit/BUILD
+++ b/plugin/pkg/admission/eventratelimit/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -15,7 +13,6 @@ go_test(
        "cache_test.go",
    ],
    library = ":go_default_library",
-    tags = ["automanaged"],
    deps = [
        "//pkg/api:go_default_library",
        "//plugin/pkg/admission/eventratelimit/apis/eventratelimit:go_default_library",
@@ -39,7 +36,6 @@ go_library(
        "doc.go",
        "limitenforcer.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//pkg/api:go_default_library",
        "//plugin/pkg/admission/eventratelimit/apis/eventratelimit:go_default_library",

--- a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/BUILD
+++ b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -15,7 +13,6 @@ go_library(
        "types.go",
        "zz_generated.deepcopy.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
        "//vendor/k8s.io/apimachinery/pkg/conversion:go_default_library",

--- a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/install/BUILD
+++ b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/install/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -10,7 +8,6 @@ load(
 go_library(
    name = "go_default_library",
    srcs = ["install.go"],
-    tags = ["automanaged"],
    deps = [
        "//plugin/pkg/admission/eventratelimit/apis/eventratelimit:go_default_library",
        "//plugin/pkg/admission/eventratelimit/apis/eventratelimit/v1alpha1:go_default_library",

--- a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/v1alpha1/BUILD
+++ b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/v1alpha1/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -18,7 +16,6 @@ go_library(
        "zz_generated.deepcopy.go",
        "zz_generated.defaults.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//plugin/pkg/admission/eventratelimit/apis/eventratelimit:go_default_library",
        "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",

--- a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/validation/BUILD
+++ b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/validation/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -11,7 +9,6 @@ load(
 go_library(
    name = "go_default_library",
    srcs = ["validation.go"],
-    tags = ["automanaged"],
    deps = [
        "//plugin/pkg/admission/eventratelimit/apis/eventratelimit:go_default_library",
        "//vendor/k8s.io/apimachinery/pkg/util/validation/field:go_default_library",
@@ -35,6 +32,5 @@ go_test(
    name = "go_default_test",
    srcs = ["validation_test.go"],
    library = ":go_default_library",
-    tags = ["automanaged"],
    deps = ["//plugin/pkg/admission/eventratelimit/apis/eventratelimit:go_default_library"],
 )
--- a/plugin/pkg/admission/persistentvolume/resize/BUILD
+++ b/plugin/pkg/admission/persistentvolume/resize/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -12,7 +10,6 @@ go_test(
    name = "go_default_test",
    srcs = ["admission_test.go"],
    library = ":go_default_library",
-    tags = ["automanaged"],
    deps = [
        "//pkg/api:go_default_library",
        "//pkg/apis/storage:go_default_library",
@@ -29,7 +26,6 @@ go_test(
 go_library(
    name = "go_default_library",
    srcs = ["admission.go"],
-    tags = ["automanaged"],
    deps = [
        "//pkg/api:go_default_library",
        "//pkg/api/helper:go_default_library",

--- a/plugin/pkg/admission/priority/BUILD
+++ b/plugin/pkg/admission/priority/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -12,7 +10,6 @@ go_test(
    name = "go_default_test",
    srcs = ["admission_test.go"],
    library = ":go_default_library",
-    tags = ["automanaged"],
    deps = [
        "//pkg/api:go_default_library",
        "//pkg/apis/scheduling:go_default_library",
@@ -29,7 +26,6 @@ go_test(
 go_library(
    name = "go_default_library",
    srcs = ["admission.go"],
-    tags = ["automanaged"],
    deps = [
        "//pkg/api:go_default_library",
        "//pkg/apis/scheduling:go_default_library",

--- a/staging/BUILD
+++ b/staging/BUILD
@@ -6,17 +6,6 @@ load(
    "go_library",
 )
-go_binary(
-    name = "staging",
-    library = ":go_default_library",
-)
-go_library(
-    name = "go_default_library",
-    srcs = ["godeps-json-updater.go"],
-    deps = ["//vendor/github.com/spf13/pflag:go_default_library"],
-)
 filegroup(
    name = "package-srcs",
    srcs = glob(["**"]),

--- a/staging/src/k8s.io/api/batch/v1beta1/BUILD
+++ b/staging/src/k8s.io/api/batch/v1beta1/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -17,7 +15,6 @@ go_library(
        "types_swagger_doc_generated.go",
        "zz_generated.deepcopy.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//vendor/github.com/gogo/protobuf/proto:go_default_library",
        "//vendor/k8s.io/api/batch/v1:go_default_library",

--- a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/validation/BUILD
+++ b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/validation/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -10,7 +8,6 @@ load(
 go_library(
    name = "go_default_library",
    srcs = ["validation.go"],
-    tags = ["automanaged"],
    deps = [
        "//vendor/github.com/go-openapi/spec:go_default_library",
        "//vendor/github.com/go-openapi/validate:go_default_library",

--- a/staging/src/k8s.io/apiserver/pkg/apis/audit/v1beta1/BUILD
+++ b/staging/src/k8s.io/apiserver/pkg/apis/audit/v1beta1/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -18,7 +16,6 @@ go_library(
        "zz_generated.deepcopy.go",
        "zz_generated.defaults.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//vendor/github.com/gogo/protobuf/proto:go_default_library",
        "//vendor/k8s.io/api/authentication/v1:go_default_library",

--- a/staging/src/k8s.io/apiserver/pkg/authentication/token/cache/BUILD
+++ b/staging/src/k8s.io/apiserver/pkg/authentication/token/cache/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -15,7 +13,6 @@ go_test(
        "cached_token_authenticator_test.go",
    ],
    library = ":go_default_library",
-    tags = ["automanaged"],
    deps = [
        "//vendor/github.com/pborman/uuid:go_default_library",
        "//vendor/k8s.io/apimachinery/pkg/util/clock:go_default_library",
@@ -31,7 +28,6 @@ go_library(
        "cache_striped.go",
        "cached_token_authenticator.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//vendor/k8s.io/apimachinery/pkg/util/cache:go_default_library",
        "//vendor/k8s.io/apimachinery/pkg/util/clock:go_default_library",

--- a/staging/src/k8s.io/apiserver/pkg/authentication/token/union/BUILD
+++ b/staging/src/k8s.io/apiserver/pkg/authentication/token/union/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -12,14 +10,12 @@ go_test(
    name = "go_default_test",
    srcs = ["unionauth_test.go"],
    library = ":go_default_library",
-    tags = ["automanaged"],
    deps = ["//vendor/k8s.io/apiserver/pkg/authentication/user:go_default_library"],
 )
 go_library(
    name = "go_default_library",
    srcs = ["union.go"],
-    tags = ["automanaged"],
    deps = [
        "//vendor/k8s.io/apimachinery/pkg/util/errors:go_default_library",
        "//vendor/k8s.io/apiserver/pkg/authentication/authenticator:go_default_library",

--- a/staging/src/k8s.io/client-go/informers/batch/v1beta1/BUILD
+++ b/staging/src/k8s.io/client-go/informers/batch/v1beta1/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -13,7 +11,6 @@ go_library(
        "cronjob.go",
        "interface.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//vendor/k8s.io/api/batch/v1beta1:go_default_library",
        "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",

--- a/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/BUILD
+++ b/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -15,7 +13,6 @@ go_library(
        "doc.go",
        "generated_expansion.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//vendor/k8s.io/api/batch/v1beta1:go_default_library",
        "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",

--- a/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/fake/BUILD
+++ b/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/fake/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -14,7 +12,6 @@ go_library(
        "fake_batch_client.go",
        "fake_cronjob.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//vendor/k8s.io/api/batch/v1beta1:go_default_library",
        "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",

--- a/staging/src/k8s.io/client-go/listers/batch/v1beta1/BUILD
+++ b/staging/src/k8s.io/client-go/listers/batch/v1beta1/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -13,7 +11,6 @@ go_library(
        "cronjob.go",
        "expansion_generated.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//vendor/k8s.io/api/batch/v1beta1:go_default_library",
        "//vendor/k8s.io/apimachinery/pkg/api/errors:go_default_library",

--- a/staging/src/k8s.io/client-go/tools/pager/BUILD
+++ b/staging/src/k8s.io/client-go/tools/pager/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -11,7 +9,6 @@ load(
 go_library(
    name = "go_default_library",
    srcs = ["pager.go"],
-    tags = ["automanaged"],
    deps = [
        "//vendor/golang.org/x/net/context:go_default_library",
        "//vendor/k8s.io/apimachinery/pkg/api/errors:go_default_library",

--- a/test/e2e/BUILD
+++ b/test/e2e/BUILD
@@ -10,6 +10,7 @@ go_test(
    name = "go_default_test",
    srcs = ["e2e_test.go"],
    library = ":go_default_library",
+    tags = ["e2e"],
    deps = [
        "//test/e2e/apimachinery:go_default_library",
        "//test/e2e/apps:go_default_library",

--- a/test/e2e/auth/BUILD
+++ b/test/e2e/auth/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -16,7 +14,6 @@ go_library(
        "node_authz.go",
        "service_accounts.go",
    ],
-    tags = ["automanaged"],
    deps = [
        "//pkg/util/version:go_default_library",
        "//plugin/pkg/admission/serviceaccount:go_default_library",

--- a/test/e2e/chaosmonkey/BUILD
+++ b/test/e2e/chaosmonkey/BUILD
@@ -16,6 +16,7 @@ go_test(
    name = "go_default_test",
    srcs = ["chaosmonkey_test.go"],
    library = ":go_default_library",
+    tags = ["e2e"],
 )
 filegroup(

--- a/test/e2e/generated/BUILD
+++ b/test/e2e/generated/BUILD
@@ -20,10 +20,10 @@ go_library(
 genrule(
    name = "bindata",
    srcs = [
-        "//examples:sources",
+        "//examples:all-srcs",
-        "//test/images:sources",
+        "//test/images:all-srcs",
-        "//test/fixtures:sources",
+        "//test/fixtures:all-srcs",
-        "//test/e2e/testing-manifests:sources",
+        "//test/e2e/testing-manifests:all-srcs",
    ],
    outs = ["bindata.go"],
    cmd = """

--- a/test/e2e/scheduling/BUILD
+++ b/test/e2e/scheduling/BUILD
@@ -66,7 +66,7 @@ go_test(
    name = "go_default_test",
    srcs = ["taints_test.go"],
    library = ":go_default_library",
-    tags = ["automanaged"],
+    tags = ["e2e"],
    deps = [
        "//test/e2e/framework:go_default_library",
        "//test/utils:go_default_library",

--- a/test/e2e/testing-manifests/BUILD
+++ b/test/e2e/testing-manifests/BUILD
 package(default_visibility = ["//visibility:public"])
 filegroup(
-    name = "sources",
-    srcs = glob([
-        "**/*",
-    ]),
-)
-filegroup(
    name = "package-srcs",
    srcs = glob(["**"]),
    tags = ["automanaged"],

--- a/test/e2e_node/BUILD
+++ b/test/e2e_node/BUILD
@@ -112,7 +112,7 @@ go_test(
        "//conditions:default": [],
    }),
    library = ":go_default_library",
-    tags = ["integration"],
+    tags = ["e2e"],
    deps = [
        "//pkg/api:go_default_library",
        "//pkg/api/v1/node:go_default_library",

--- a/test/e2e_node/system/BUILD
+++ b/test/e2e_node/system/BUILD
@@ -38,6 +38,7 @@ go_test(
        "package_validator_test.go",
    ],
    library = ":go_default_library",
+    tags = ["e2e"],
    deps = [
        "//vendor/github.com/docker/docker/api/types:go_default_library",
        "//vendor/github.com/stretchr/testify/assert:go_default_library",

--- a/test/fixtures/BUILD
+++ b/test/fixtures/BUILD
@@ -10,13 +10,6 @@ filegroup(
 )
 filegroup(
-    name = "sources",
-    srcs = glob([
-        "**/*",
-    ]),
-)
-filegroup(
    name = "package-srcs",
    srcs = glob(["**"]),
    tags = ["automanaged"],

--- a/test/images/BUILD
+++ b/test/images/BUILD
 package(default_visibility = ["//visibility:public"])
 filegroup(
-    name = "sources",
-    srcs = glob([
-        "**/*",
-    ]),
-)
-filegroup(
    name = "package-srcs",
    srcs = glob(["**"]),
    tags = ["automanaged"],

--- a/test/images/nonewprivs/BUILD
+++ b/test/images/nonewprivs/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_binary",
@@ -11,13 +9,11 @@ load(
 go_binary(
    name = "nonewprivs",
    library = ":go_default_library",
-    tags = ["automanaged"],
 )
 go_library(
    name = "go_default_library",
    srcs = ["nnp.go"],
-    tags = ["automanaged"],
 )
 filegroup(

--- a/test/images/pets/peer-finder/BUILD
+++ b/test/images/pets/peer-finder/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_binary",
@@ -11,13 +9,11 @@ load(
 go_binary(
    name = "peer-finder",
    library = ":go_default_library",
-    tags = ["automanaged"],
 )
 go_library(
    name = "go_default_library",
    srcs = ["peer-finder.go"],
-    tags = ["automanaged"],
    deps = ["//vendor/k8s.io/apimachinery/pkg/util/sets:go_default_library"],
 )

--- a/test/integration/deployment/BUILD
+++ b/test/integration/deployment/BUILD
@@ -14,6 +14,7 @@ go_test(
        "main_test.go",
    ],
    library = ":go_default_library",
+    tags = ["integration"],
    deps = [
        "//pkg/controller/deployment/util:go_default_library",
        "//test/integration/framework:go_default_library",

--- a/test/utils/image/BUILD
+++ b/test/utils/image/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -10,7 +8,6 @@ load(
 go_library(
    name = "go_default_library",
    srcs = ["manifest.go"],
-    tags = ["automanaged"],
 )
 filegroup(

--- a/vendor/github.com/vishvananda/netns/BUILD
+++ b/vendor/github.com/vishvananda/netns/BUILD
 package(default_visibility = ["//visibility:public"])
-licenses(["notice"])
 load(
    "@io_bazel_rules_go//go:def.bzl",
    "go_library",
@@ -18,7 +16,6 @@ go_library(
        ],
        "//conditions:default": [],
    }),
-    tags = ["automanaged"],
 )
 filegroup(