Commit 7c82fe73 authored by Justin Santa Barbara's avatar Justin Santa Barbara

AWS: Increase timeout deleting ELB; log remaining security groups

Either ELB is slow to delete (in which case the bumped timeout will help), or the security groups are otherwise blocked (in which case logging them will help us track this down). Fix #17626
parent d7a87c22
...@@ -2510,7 +2510,7 @@ func (s *AWSCloud) EnsureLoadBalancerDeleted(name, region string) error { ...@@ -2510,7 +2510,7 @@ func (s *AWSCloud) EnsureLoadBalancerDeleted(name, region string) error {
} }
// Loop through and try to delete them // Loop through and try to delete them
timeoutAt := time.Now().Add(time.Second * 300) timeoutAt := time.Now().Add(time.Second * 600)
for { for {
for securityGroupID := range securityGroupIDs { for securityGroupID := range securityGroupIDs {
request := &ec2.DeleteSecurityGroupInput{} request := &ec2.DeleteSecurityGroupInput{}
...@@ -2538,12 +2538,17 @@ func (s *AWSCloud) EnsureLoadBalancerDeleted(name, region string) error { ...@@ -2538,12 +2538,17 @@ func (s *AWSCloud) EnsureLoadBalancerDeleted(name, region string) error {
} }
if time.Now().After(timeoutAt) { if time.Now().After(timeoutAt) {
return fmt.Errorf("timed out waiting for load-balancer deletion: %s", name) ids := []string{}
for id := range securityGroupIDs {
ids = append(ids, id)
}
return fmt.Errorf("timed out deleting ELB: %s. Could not delete security groups %v", name, strings.Join(ids, ","))
} }
glog.V(2).Info("Waiting for load-balancer to delete so we can delete security groups: ", name) glog.V(2).Info("Waiting for load-balancer to delete so we can delete security groups: ", name)
time.Sleep(5 * time.Second) time.Sleep(10 * time.Second)
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment