Commit 7c05607a authored by Robert Bailey's avatar Robert Bailey

Revert #19469 so re-enable the metrics grabbing test on GKE.

parent 62e57434
...@@ -100,15 +100,12 @@ var _ = Describe("MetricsGrabber", func() { ...@@ -100,15 +100,12 @@ var _ = Describe("MetricsGrabber", func() {
}) })
It("should grab all metrics from a Kubelet.", func() { It("should grab all metrics from a Kubelet.", func() {
// We run this test only on GCE, as for some reason it flakes in GKE #19468 By("Proxying to Node through the API server")
if providerIs("gce") { nodes := ListSchedulableNodesOrDie(c)
By("Proxying to Node through the API server") Expect(nodes.Items).NotTo(BeEmpty())
nodes := ListSchedulableNodesOrDie(c) response, err := grabber.GrabFromKubelet(nodes.Items[0].Name)
Expect(nodes.Items).NotTo(BeEmpty()) expectNoError(err)
response, err := grabber.GrabFromKubelet(nodes.Items[0].Name) checkNecessaryMetrics(metrics.Metrics(response), metrics.NecessaryKubeletMetrics)
expectNoError(err)
checkNecessaryMetrics(metrics.Metrics(response), metrics.NecessaryKubeletMetrics)
}
}) })
It("should grab all metrics from a Scheduler.", func() { It("should grab all metrics from a Scheduler.", func() {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment