Avoid string concatenation when comparing pods.

Pod comparison in (*NodeInfo).Filter was using GetPodFullName before comparing pod names. This is a concatenation of pod name and pod namespace, and it is significantly faster to compare name & namespace instead.

Avoid string concatenation when comparing pods.
7b3638ea · Jonathan Basseri · 8bd5a460 · 7b3638ea
Commit 7b3638ea authored Dec 19, 2017 by Jonathan Basseri
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 2 deletions

node_info.go plugin/pkg/scheduler/schedulercache/node_info.go +1 -2

No files found.
--- a/plugin/pkg/scheduler/schedulercache/node_info.go
+++ b/plugin/pkg/scheduler/schedulercache/node_info.go
@@ -510,12 +510,11 @@ func getPodKey(pod *v1.Pod) (string, error) {
 // matches NodeInfo.node and the pod is not found in the pods list. Otherwise,
 // returns true.
 func (n *NodeInfo) Filter(pod *v1.Pod) bool {
-	pFullName := util.GetPodFullName(pod)
 	if pod.Spec.NodeName != n.node.Name {
 		return true
 	}
 	for _, p := range n.pods {
-		if util.GetPodFullName(p) == pFullName {
+		if p.Name == pod.Name && p.Namespace == pod.Namespace {
 			return true
 		}
 	}