Skip to content

K
k3s
Commit 7af6ddd3 authored by Kenichi Omichi's avatar Kenichi Omichi
Browse files
Options

Fix golint failures of framework/metrics_util.go

This fixes golint failures of framework/metrics_util.go. Cleanup: - SaturationTime was only used in test/e2e/scalability/density.go. So this moves it into the e2e test. - interestingClusterAutoscalerMetrics was not used in filterMetrics() so this removes the related code.
parent 46c8b075
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 8 additions and 1 deletion
test/e2e/scalability/density.go
View file @ 7af6ddd3
...@@ -81,6 +81,13 @@ type DensityTestConfig struct { ...@@ -81,6 +81,13 @@ type DensityTestConfig struct {
DaemonConfigs []*testutils.DaemonConfig DaemonConfigs []*testutils.DaemonConfig
} }
type saturationTime struct {
TimeToSaturate time.Duration `json:"timeToSaturate"`
NumberOfNodes int `json:"numberOfNodes"`
NumberOfPods int `json:"numberOfPods"`
Throughput float32 `json:"throughput"`
}
func (dtc *DensityTestConfig) runSecretConfigs(testPhase *timer.Phase) { func (dtc *DensityTestConfig) runSecretConfigs(testPhase *timer.Phase) {
defer testPhase.End() defer testPhase.End()
for _, sc := range dtc.SecretConfigs { for _, sc := range dtc.SecretConfigs {
...@@ -418,7 +425,7 @@ var _ = SIGDescribe("Density", func() { ...@@ -418,7 +425,7 @@ var _ = SIGDescribe("Density", func() {
saturationThreshold = MinSaturationThreshold saturationThreshold = MinSaturationThreshold
} }
Expect(e2eStartupTime).NotTo(BeNumerically(">", saturationThreshold)) Expect(e2eStartupTime).NotTo(BeNumerically(">", saturationThreshold))
saturationData := framework.SaturationTime{ saturationData := saturationTime{
TimeToSaturate: e2eStartupTime, TimeToSaturate: e2eStartupTime,
NumberOfNodes: nodeCount, NumberOfNodes: nodeCount,
NumberOfPods: totalPods, NumberOfPods: totalPods,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment