Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
79f3135d
Commit
79f3135d
authored
Jan 29, 2019
by
Antoine Pelisse
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add object information on FieldManager failures
parent
6b2e4682
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
5 deletions
+5
-5
create.go
...ing/src/k8s.io/apiserver/pkg/endpoints/handlers/create.go
+2
-2
patch.go
staging/src/k8s.io/apiserver/pkg/endpoints/handlers/patch.go
+2
-2
update.go
...ing/src/k8s.io/apiserver/pkg/endpoints/handlers/update.go
+1
-1
No files found.
staging/src/k8s.io/apiserver/pkg/endpoints/handlers/create.go
View file @
79f3135d
...
@@ -137,13 +137,13 @@ func createHandler(r rest.NamedCreater, scope RequestScope, admit admission.Inte
...
@@ -137,13 +137,13 @@ func createHandler(r rest.NamedCreater, scope RequestScope, admit admission.Inte
if
scope
.
FieldManager
!=
nil
{
if
scope
.
FieldManager
!=
nil
{
liveObj
,
err
:=
scope
.
Creater
.
New
(
scope
.
Kind
)
liveObj
,
err
:=
scope
.
Creater
.
New
(
scope
.
Kind
)
if
err
!=
nil
{
if
err
!=
nil
{
scope
.
err
(
fmt
.
Errorf
(
"failed to create new object
: %v"
,
err
),
w
,
req
)
scope
.
err
(
fmt
.
Errorf
(
"failed to create new object
(Create for %v): %v"
,
scope
.
Kind
,
err
),
w
,
req
)
return
return
}
}
obj
,
err
=
scope
.
FieldManager
.
Update
(
liveObj
,
obj
,
prefixFromUserAgent
(
req
.
UserAgent
()))
obj
,
err
=
scope
.
FieldManager
.
Update
(
liveObj
,
obj
,
prefixFromUserAgent
(
req
.
UserAgent
()))
if
err
!=
nil
{
if
err
!=
nil
{
scope
.
err
(
fmt
.
Errorf
(
"failed to update object
managed fields: %v"
,
err
),
w
,
req
)
scope
.
err
(
fmt
.
Errorf
(
"failed to update object
(Create for %v) managed fields: %v"
,
scope
.
Kind
,
err
),
w
,
req
)
return
return
}
}
}
}
...
...
staging/src/k8s.io/apiserver/pkg/endpoints/handlers/patch.go
View file @
79f3135d
...
@@ -312,7 +312,7 @@ func (p *jsonPatcher) applyPatchToCurrentObject(currentObject runtime.Object) (r
...
@@ -312,7 +312,7 @@ func (p *jsonPatcher) applyPatchToCurrentObject(currentObject runtime.Object) (r
if
p
.
fieldManager
!=
nil
{
if
p
.
fieldManager
!=
nil
{
if
objToUpdate
,
err
=
p
.
fieldManager
.
Update
(
currentObject
,
objToUpdate
,
prefixFromUserAgent
(
p
.
userAgent
));
err
!=
nil
{
if
objToUpdate
,
err
=
p
.
fieldManager
.
Update
(
currentObject
,
objToUpdate
,
prefixFromUserAgent
(
p
.
userAgent
));
err
!=
nil
{
return
nil
,
fmt
.
Errorf
(
"failed to update object
managed fields: %v"
,
err
)
return
nil
,
fmt
.
Errorf
(
"failed to update object
(json PATCH for %v) managed fields: %v"
,
p
.
kind
,
err
)
}
}
}
}
return
objToUpdate
,
nil
return
objToUpdate
,
nil
...
@@ -374,7 +374,7 @@ func (p *smpPatcher) applyPatchToCurrentObject(currentObject runtime.Object) (ru
...
@@ -374,7 +374,7 @@ func (p *smpPatcher) applyPatchToCurrentObject(currentObject runtime.Object) (ru
if
p
.
fieldManager
!=
nil
{
if
p
.
fieldManager
!=
nil
{
if
newObj
,
err
=
p
.
fieldManager
.
Update
(
currentObject
,
newObj
,
prefixFromUserAgent
(
p
.
userAgent
));
err
!=
nil
{
if
newObj
,
err
=
p
.
fieldManager
.
Update
(
currentObject
,
newObj
,
prefixFromUserAgent
(
p
.
userAgent
));
err
!=
nil
{
return
nil
,
fmt
.
Errorf
(
"failed to update object
managed fields: %v"
,
err
)
return
nil
,
fmt
.
Errorf
(
"failed to update object
(smp PATCH for %v) managed fields: %v"
,
p
.
kind
,
err
)
}
}
}
}
return
newObj
,
nil
return
newObj
,
nil
...
...
staging/src/k8s.io/apiserver/pkg/endpoints/handlers/update.go
View file @
79f3135d
...
@@ -125,7 +125,7 @@ func UpdateResource(r rest.Updater, scope RequestScope, admit admission.Interfac
...
@@ -125,7 +125,7 @@ func UpdateResource(r rest.Updater, scope RequestScope, admit admission.Interfac
if
scope
.
FieldManager
!=
nil
{
if
scope
.
FieldManager
!=
nil
{
transformers
=
append
(
transformers
,
func
(
_
context
.
Context
,
newObj
,
liveObj
runtime
.
Object
)
(
runtime
.
Object
,
error
)
{
transformers
=
append
(
transformers
,
func
(
_
context
.
Context
,
newObj
,
liveObj
runtime
.
Object
)
(
runtime
.
Object
,
error
)
{
if
obj
,
err
=
scope
.
FieldManager
.
Update
(
liveObj
,
newObj
,
prefixFromUserAgent
(
req
.
UserAgent
()));
err
!=
nil
{
if
obj
,
err
=
scope
.
FieldManager
.
Update
(
liveObj
,
newObj
,
prefixFromUserAgent
(
req
.
UserAgent
()));
err
!=
nil
{
return
nil
,
fmt
.
Errorf
(
"failed to update object
managed fields: %v"
,
err
)
return
nil
,
fmt
.
Errorf
(
"failed to update object
(Update for %v) managed fields: %v"
,
scope
.
Kind
,
err
)
}
}
return
obj
,
nil
return
obj
,
nil
})
})
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment