Merge pull request #41026 from apprenda/kubeadm_fix_os_remove

Automatic merge from submit-queue (batch tested with PRs 40385, 40786, 40999, 41026, 40996) kubeadm: change os.Remove to os.RemoveAll **What this PR does / why we need it**: This would not correctly clean out the tmp dir, since os.Remove doesn't recursively remove dirs, which could exist in the tmp dir. Unit tests are a WIP from #34136 **Special notes for your reviewer**: /cc @luxas @pires **Release note**: ```release-note NONE ```

Merge pull request #41026 from apprenda/kubeadm_fix_os_remove
751cbc9b · Kubernetes Submit Queue · GitHub · e0db0932 · 011629fb · 751cbc9b
Commit 751cbc9b authored Feb 06, 2017 by Kubernetes Submit Queue Committed by GitHub Feb 06, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

certs_test.go cmd/kubeadm/app/phases/certs/certs_test.go +1 -1

No files found.
--- a/cmd/kubeadm/app/phases/certs/certs_test.go
+++ b/cmd/kubeadm/app/phases/certs/certs_test.go
@@ -32,7 +32,7 @@ func TestCreatePKIAssets(t *testing.T) {
 	if err != nil {
 		t.Fatalf("Couldn't create tmpdir")
 	}
-	defer os.Remove(tmpdir)
+	defer os.RemoveAll(tmpdir)

 	var tests = []struct {
 		cfg      *kubeadmapi.MasterConfiguration