Merge pull request #53997 from tallclair/docs-owners

Automatic merge from submit-queue (batch tested with PRs 52717, 54568, 54452, 53997, 54237). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Copy api/OWNERS to docs/api-reference So that API changes can be approved by API approvers. Also, create api-{approvers,reviewers} aliases. Suggested by @cblecker in https://github.com/kubernetes/kubernetes/pull/53911#issuecomment-336612394

Merge pull request #53997 from tallclair/docs-owners
75115b08 · Kubernetes Submit Queue · GitHub · 5fcc1dd1 · 83fd943c · 75115b08
Commit 75115b08 authored Oct 25, 2017 by Kubernetes Submit Queue Committed by GitHub Oct 25, 2017
6 changed files
--- a/OWNERS_ALIASES
+++ b/OWNERS_ALIASES
@@ -175,4 +175,47 @@ aliases:
    - radhikpac
    - jpbetz
    - cmluciano
-
+  api-approvers:
+    - erictune
+    - lavalamp
+    - smarterclayton
+    - thockin
+    - liggitt
+    # - bgrant0607 # manual escalations only
+  api-reviewers:
+    - erictune
+    - lavalamp
+    - smarterclayton
+    - thockin
+    - liggitt
+    - wojtek-t
+    - deads2k
+    - yujuhong
+    - brendandburns
+    - derekwaynecarr
+    - caesarxuchao
+    - vishh
+    - mikedanese
+    - nikhiljindal
+    - gmarek
+    - davidopp
+    - pmorie
+    - sttts
+    - dchen1107
+    - saad-ali
+    - zmerlynn
+    - luxas
+    - janetkuo
+    - justinsb
+    - pwittrock
+    - roberthbailey
+    - ncdc
+    - tallclair
+    - yifan-gu
+    - eparis
+    - mwielgus
+    - timothysc
+    - soltysh
+    - piosz
+    - jsafrane
+    - jbeda
--- a/api/OWNERS
+++ b/api/OWNERS
 approvers:
- erictune
- lavalamp
- smarterclayton
- thockin
- liggitt
-# - bgrant0607 # manual	escalations only
+- api-approvers
 reviewers:
- thockin
- lavalamp
- smarterclayton
- wojtek-t
- deads2k
- yujuhong
- brendandburns
- derekwaynecarr
- caesarxuchao
- vishh
- mikedanese
- liggitt
- nikhiljindal
- gmarek
- erictune
- davidopp
- pmorie
- sttts
- dchen1107
- saad-ali
- zmerlynn
- luxas
- janetkuo
- justinsb
- pwittrock
- roberthbailey
- ncdc
- tallclair
- yifan-gu
- eparis
- mwielgus
- timothysc
- soltysh
- piosz
- jsafrane
- jbeda
+- api-reviewers
--- a/docs/api-reference/OWNERS
+++ b/docs/api-reference/OWNERS
+approvers:
+- api-approvers
+reviewers:
+- api-reviewers
--- a/hack/verify-api-reference-docs.sh
+++ b/hack/verify-api-reference-docs.sh
@@ -36,7 +36,7 @@ trap "rm -rf ${TMP_ROOT}" EXIT SIGINT

 echo "diffing ${API_REFERENCE_DOCS_ROOT} against freshly generated docs"
 ret=0
-diff -NauprB -I 'Last update' --exclude=*.md "${API_REFERENCE_DOCS_ROOT}" "${OUTPUT_DIR}" || ret=$?
+diff -NauprB -I 'Last update' --exclude=*.md --exclude=OWNERS "${API_REFERENCE_DOCS_ROOT}" "${OUTPUT_DIR}" || ret=$?
 if [[ $ret -eq 0 ]]
 then
  echo "${API_REFERENCE_DOCS_ROOT} up to date."

--- a/pkg/api/OWNERS
+++ b/pkg/api/OWNERS
 approvers:
- erictune
- lavalamp
- smarterclayton
- thockin
- liggitt
-# - bgrant0607 # manual escalations only
+- api-approvers
 reviewers:
- thockin
- lavalamp
- smarterclayton
- wojtek-t
- deads2k
- yujuhong
- brendandburns
- derekwaynecarr
- caesarxuchao
- vishh
- mikedanese
- liggitt
- nikhiljindal
- gmarek
- erictune
- davidopp
- pmorie
- sttts
- dchen1107
- saad-ali
- zmerlynn
- luxas
- janetkuo
- justinsb
- pwittrock
- roberthbailey
- ncdc
- tallclair
- yifan-gu
- eparis
- mwielgus
- timothysc
- soltysh
- piosz
- jsafrane
- jbeda
+- api-reviewers
--- a/staging/src/k8s.io/api/core/OWNERS
+++ b/staging/src/k8s.io/api/core/OWNERS
-approvers:
- erictune
- lavalamp
- smarterclayton
- thockin
-reviewers:
- thockin
- lavalamp
- smarterclayton
- wojtek-t
- deads2k
- yujuhong
- brendandburns
- derekwaynecarr
- caesarxuchao
- vishh
- mikedanese
- liggitt
- nikhiljindal
- gmarek
- erictune
- davidopp
- pmorie
- sttts
- dchen1107
- saad-ali
- zmerlynn
- luxas
- janetkuo
- justinsb
- pwittrock
- roberthbailey
- ncdc
- tallclair
- yifan-gu
- eparis
- mwielgus
- timothysc
- soltysh
- piosz
- jsafrane
- jbeda