Commit 74de0fdb authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #38135 from MHBauer/go-generate-flag-location

Automatic merge from submit-queue goflags must be after subcommand **What this PR does / why we need it**: if GOFLAGS is set when calling make, kubernetes will fail to build as an example, I often have `GOFLAGS=-v` so I can have some idea of progress during compilation **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: no known issue **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
parents 00e5777b 3114920d
......@@ -672,7 +672,7 @@ kube::golang::build_binaries() {
# Only try to generate bindata if the file exists, since in some cases
# one-off builds of individual directories may exclude some files.
if [[ -f "${KUBE_ROOT}/${bindata}" ]]; then
go "${goflags[@]:+${goflags[@]}}" generate "${KUBE_ROOT}/${bindata}"
go generate "${goflags[@]:+${goflags[@]}}" "${KUBE_ROOT}/${bindata}"
fi
done
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment