Commit 6ec2bdf9 authored by Davanum Srinivas's avatar Davanum Srinivas

Allow config and ignore-preflight to be specified together

In commit 3a0aa06f, the flag was changed from `ignore-checks-errors` to `ignore-preflight-errors`, but the condition check in ValidateMixedArguments was not updated. So specifying say `--config kubeadm.conf --ignore-preflight-errors all` would fail.
parent 76287fed
...@@ -315,7 +315,7 @@ func ValidateMixedArguments(flag *pflag.FlagSet) error { ...@@ -315,7 +315,7 @@ func ValidateMixedArguments(flag *pflag.FlagSet) error {
mixedInvalidFlags := []string{} mixedInvalidFlags := []string{}
flag.Visit(func(f *pflag.Flag) { flag.Visit(func(f *pflag.Flag) {
if f.Name == "config" || strings.HasPrefix(f.Name, "ignore-checks-") || strings.HasPrefix(f.Name, "skip-") || f.Name == "dry-run" || f.Name == "kubeconfig" { if f.Name == "config" || f.Name == "ignore-preflight-errors" || strings.HasPrefix(f.Name, "skip-") || f.Name == "dry-run" || f.Name == "kubeconfig" {
// "--skip-*" flags or other whitelisted flags can be set with --config // "--skip-*" flags or other whitelisted flags can be set with --config
return return
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment