Make REST mappings for resources a unique list

This ensures the mappings list for resources(shortcuts, plural) unique, instead of doing multiple requests to server for the same resource.

Make REST mappings for resources a unique list
6be1b975 · Zhenguo Niu · 8f4f07fc · 6be1b975
Commit 6be1b975 authored Dec 21, 2017 by Zhenguo Niu
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

builder.go pkg/kubectl/resource/builder.go +6 -0

No files found.
--- a/pkg/kubectl/resource/builder.go
+++ b/pkg/kubectl/resource/builder.go
@@ -622,11 +622,17 @@ func (b *Builder) resourceMappings() ([]*meta.RESTMapping, error) {
 		return nil, fmt.Errorf("you may only specify a single resource type")
 	}
 	mappings := []*meta.RESTMapping{}
+	seen := map[schema.GroupVersionKind]bool{}
 	for _, r := range b.resources {
 		mapping, err := b.mappingFor(r)
 		if err != nil {
 			return nil, err
 		}
+		// This ensures the mappings for resources(shortcuts, plural) unique
+		if seen[mapping.GroupVersionKind] {
+			continue
+		}
+		seen[mapping.GroupVersionKind] = true

 		mappings = append(mappings, mapping)
 	}