Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
6b5c8f1d
Commit
6b5c8f1d
authored
Jan 18, 2017
by
peay
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Emit warning when CronJob cannot determine starting time
parent
56b1082d
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
60 additions
and
44 deletions
+60
-44
cronjob_controller.go
pkg/controller/cronjob/cronjob_controller.go
+1
-0
cronjob_controller_test.go
pkg/controller/cronjob/cronjob_controller_test.go
+59
-44
No files found.
pkg/controller/cronjob/cronjob_controller.go
View file @
6b5c8f1d
...
@@ -174,6 +174,7 @@ func SyncOne(sj batch.CronJob, js []batch.Job, now time.Time, jc jobControlInter
...
@@ -174,6 +174,7 @@ func SyncOne(sj batch.CronJob, js []batch.Job, now time.Time, jc jobControlInter
}
}
times
,
err
:=
getRecentUnmetScheduleTimes
(
sj
,
now
)
times
,
err
:=
getRecentUnmetScheduleTimes
(
sj
,
now
)
if
err
!=
nil
{
if
err
!=
nil
{
recorder
.
Eventf
(
&
sj
,
v1
.
EventTypeWarning
,
"FailedNeedsStart"
,
"Cannot determine if job needs to be started: %v"
,
err
)
glog
.
Errorf
(
"Cannot determine if %s needs to be started: %v"
,
nameForLog
,
err
)
glog
.
Errorf
(
"Cannot determine if %s needs to be started: %v"
,
nameForLog
,
err
)
}
}
// TODO: handle multiple unmet start times, from oldest to newest, updating status as needed.
// TODO: handle multiple unmet start times, from oldest to newest, updating status as needed.
...
...
pkg/controller/cronjob/cronjob_controller_test.go
View file @
6b5c8f1d
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment