Merge pull request #46069 from waseem/variadic-command-addition-to-parent-command

Automatic merge from submit-queue Use variadic nature of *cobra.Command.AddCommand to add group of commands to a parent command **What this PR does / why we need it**: Rather than looping over commands in a group and add it one by one to a parent command, use variadic nature of *cobra.Command.AddCommand to add the group of commands to the parent.

Merge pull request #46069 from waseem/variadic-command-addition-to-parent-command
6a0d3c74 · Kubernetes Submit Queue · GitHub · 3655685d · 958a7113 · 6a0d3c74
Commit 6a0d3c74 authored Aug 09, 2017 by Kubernetes Submit Queue Committed by GitHub Aug 09, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 3 deletions

command_groups.go pkg/kubectl/cmd/templates/command_groups.go +1 -3

No files found.
--- a/pkg/kubectl/cmd/templates/command_groups.go
+++ b/pkg/kubectl/cmd/templates/command_groups.go
@@ -29,9 +29,7 @@ type CommandGroups []CommandGroup

 func (g CommandGroups) Add(c *cobra.Command) {
 	for _, group := range g {
-		for _, command := range group.Commands {
-			c.AddCommand(command)
-		}
+		c.AddCommand(group.Commands...)
 	}
 }