Merge pull request #59027 from YuxiJin-tobeyjin/add-ut-for-legacyLogSymlink

Automatic merge from submit-queue (batch tested with PRs 59027, 62333, 57661, 62086, 61584). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add UT case to cover the func legacyLogSymlink in legacy.go **What this PR does / why we need it**: Add UT case to cover the func legacyLogSymlink in legacy.go. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note "NONE" ```

Merge pull request #59027 from YuxiJin-tobeyjin/add-ut-for-legacyLogSymlink
6816227d · Kubernetes Submit Queue · GitHub · 27045d3f · dc873efc · 6816227d
Unverified Commit 6816227d authored Apr 10, 2018 by Kubernetes Submit Queue Committed by GitHub Apr 10, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 11 additions and 0 deletions

legacy_test.go pkg/kubelet/kuberuntime/legacy_test.go +11 -0

No files found.
--- a/pkg/kubelet/kuberuntime/legacy_test.go
+++ b/pkg/kubelet/kuberuntime/legacy_test.go
@@ -45,3 +45,14 @@ func TestLogSymLink(t *testing.T) {
 	expectedPath := path.Join(containerLogsDir, fmt.Sprintf("%s_%s-%s", podFullName, containerName, dockerId)[:251]+".log")
 	as.Equal(expectedPath, logSymlink(containerLogsDir, podFullName, containerName, dockerId))
 }
+func TestLegacyLogSymLink(t *testing.T) {
+	as := assert.New(t)
+	containerID := randStringBytes(80)
+	containerName := randStringBytes(70)
+	podName := randStringBytes(128)
+	podNamespace := randStringBytes(10)
+	// The file name cannot exceed 255 characters. Since .log suffix is required, the prefix cannot exceed 251 characters.
+	expectedPath := path.Join(legacyContainerLogsDir, fmt.Sprintf("%s_%s_%s-%s", podName, podNamespace, containerName, containerID)[:251]+".log")
+	as.Equal(expectedPath, legacyLogSymlink(containerID, containerName, podName, podNamespace))
+}