Merge pull request #54854 from kawych/hpa_roles

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Allow HPA to get custom metrics **What this PR does / why we need it**: This PR allows HPA to read custom metrics. **Release note**: ```release-note Allow HPA to read custom metrics. ```

Merge pull request #54854 from kawych/hpa_roles
648cc300 · Kubernetes Submit Queue · GitHub · 6e1b4ab8 · 69d81c92 · 648cc300
Unverified Commit 648cc300 authored Nov 08, 2017 by Kubernetes Submit Queue Committed by GitHub Nov 08, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

controller_policy.go ...auth/authorizer/rbac/bootstrappolicy/controller_policy.go +1 -1

controller-roles.yaml ...rizer/rbac/bootstrappolicy/testdata/controller-roles.yaml +1 -0

No files found.
--- a/plugin/pkg/auth/authorizer/rbac/bootstrappolicy/controller_policy.go
+++ b/plugin/pkg/auth/authorizer/rbac/bootstrappolicy/controller_policy.go
@@ -162,7 +162,7 @@ func buildControllerRoles() ([]rbac.ClusterRole, []rbac.ClusterRoleBinding) {
 			rbac.NewRule("get").Groups(legacyGroup).Resources("services/proxy").Names("https:heapster:", "http:heapster:").RuleOrDie(),
 			// allow listing resource metrics and custom metrics
 			rbac.NewRule("list").Groups(resMetricsGroup).Resources("pods").RuleOrDie(),
-			rbac.NewRule("list").Groups(customMetricsGroup).Resources("*").RuleOrDie(),
+			rbac.NewRule("get", "list").Groups(customMetricsGroup).Resources("*").RuleOrDie(),
 			eventsRule(),
 		},
 	})

--- a/plugin/pkg/auth/authorizer/rbac/bootstrappolicy/testdata/controller-roles.yaml
+++ b/plugin/pkg/auth/authorizer/rbac/bootstrappolicy/testdata/controller-roles.yaml
@@ -479,6 +479,7 @@ items:
    resources:
    - '*'
    verbs:
+    - get
    - list
  - apiGroups:
    - ""