Commit 62e4635c authored by Dan Williams's avatar Dan Williams

rkt: set up network namespace with plugins

parent 9b85d20c
...@@ -439,6 +439,8 @@ func NewMainKubelet( ...@@ -439,6 +439,8 @@ func NewMainKubelet(
klet.livenessManager, klet.livenessManager,
klet.volumeManager, klet.volumeManager,
klet.httpClient, klet.httpClient,
klet.networkPlugin,
klet.hairpinMode == componentconfig.HairpinVeth,
utilexec.New(), utilexec.New(),
kubecontainer.RealOS{}, kubecontainer.RealOS{},
imageBackOff, imageBackOff,
......
...@@ -1076,8 +1076,9 @@ func TestSetApp(t *testing.T) { ...@@ -1076,8 +1076,9 @@ func TestSetApp(t *testing.T) {
func TestGenerateRunCommand(t *testing.T) { func TestGenerateRunCommand(t *testing.T) {
hostName := "test-hostname" hostName := "test-hostname"
tests := []struct { tests := []struct {
pod *api.Pod pod *api.Pod
uuid string uuid string
netnsName string
dnsServers []string dnsServers []string
dnsSearches []string dnsSearches []string
...@@ -1095,6 +1096,7 @@ func TestGenerateRunCommand(t *testing.T) { ...@@ -1095,6 +1096,7 @@ func TestGenerateRunCommand(t *testing.T) {
Spec: api.PodSpec{}, Spec: api.PodSpec{},
}, },
"rkt-uuid-foo", "rkt-uuid-foo",
"default",
[]string{}, []string{},
[]string{}, []string{},
"", "",
...@@ -1109,11 +1111,12 @@ func TestGenerateRunCommand(t *testing.T) { ...@@ -1109,11 +1111,12 @@ func TestGenerateRunCommand(t *testing.T) {
}, },
}, },
"rkt-uuid-foo", "rkt-uuid-foo",
"default",
[]string{}, []string{},
[]string{}, []string{},
"pod-hostname-foo", "pod-hostname-foo",
nil, nil,
"/bin/rkt/rkt --insecure-options=image,ondisk --local-config=/var/rkt/local/data --dir=/var/data run-prepared --net=rkt.kubernetes.io --hostname=pod-hostname-foo rkt-uuid-foo", " --net=\"/var/run/netns/default\" -- /bin/rkt/rkt --insecure-options=image,ondisk --local-config=/var/rkt/local/data --dir=/var/data run-prepared --net=host --hostname=pod-hostname-foo rkt-uuid-foo",
}, },
// Case #2, returns no dns, with host-net. // Case #2, returns no dns, with host-net.
{ {
...@@ -1128,6 +1131,7 @@ func TestGenerateRunCommand(t *testing.T) { ...@@ -1128,6 +1131,7 @@ func TestGenerateRunCommand(t *testing.T) {
}, },
}, },
"rkt-uuid-foo", "rkt-uuid-foo",
"",
[]string{}, []string{},
[]string{}, []string{},
"", "",
...@@ -1147,11 +1151,12 @@ func TestGenerateRunCommand(t *testing.T) { ...@@ -1147,11 +1151,12 @@ func TestGenerateRunCommand(t *testing.T) {
}, },
}, },
"rkt-uuid-foo", "rkt-uuid-foo",
"default",
[]string{"127.0.0.1"}, []string{"127.0.0.1"},
[]string{"."}, []string{"."},
"pod-hostname-foo", "pod-hostname-foo",
nil, nil,
"/bin/rkt/rkt --insecure-options=image,ondisk --local-config=/var/rkt/local/data --dir=/var/data run-prepared --net=rkt.kubernetes.io --dns=127.0.0.1 --dns-search=. --dns-opt=ndots:5 --hostname=pod-hostname-foo rkt-uuid-foo", " --net=\"/var/run/netns/default\" -- /bin/rkt/rkt --insecure-options=image,ondisk --local-config=/var/rkt/local/data --dir=/var/data run-prepared --net=host --dns=127.0.0.1 --dns-search=. --dns-opt=ndots:5 --hostname=pod-hostname-foo rkt-uuid-foo",
}, },
// Case #4, returns no dns, dns searches, with host-network. // Case #4, returns no dns, dns searches, with host-network.
{ {
...@@ -1166,6 +1171,7 @@ func TestGenerateRunCommand(t *testing.T) { ...@@ -1166,6 +1171,7 @@ func TestGenerateRunCommand(t *testing.T) {
}, },
}, },
"rkt-uuid-foo", "rkt-uuid-foo",
"",
[]string{"127.0.0.1"}, []string{"127.0.0.1"},
[]string{"."}, []string{"."},
"pod-hostname-foo", "pod-hostname-foo",
...@@ -1189,7 +1195,7 @@ func TestGenerateRunCommand(t *testing.T) { ...@@ -1189,7 +1195,7 @@ func TestGenerateRunCommand(t *testing.T) {
testCaseHint := fmt.Sprintf("test case #%d", i) testCaseHint := fmt.Sprintf("test case #%d", i)
rkt.runtimeHelper = &fakeRuntimeHelper{tt.dnsServers, tt.dnsSearches, tt.hostName, "", tt.err} rkt.runtimeHelper = &fakeRuntimeHelper{tt.dnsServers, tt.dnsSearches, tt.hostName, "", tt.err}
result, err := rkt.generateRunCommand(tt.pod, tt.uuid) result, err := rkt.generateRunCommand(tt.pod, tt.uuid, tt.netnsName)
assert.Equal(t, tt.err, err, testCaseHint) assert.Equal(t, tt.err, err, testCaseHint)
assert.Equal(t, tt.expect, result, testCaseHint) assert.Equal(t, tt.expect, result, testCaseHint)
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment