Skip to content

K
k3s
Unverified Commit 60836d0d authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #59471 from dmathieu/remove-cronjob-from-client

Automatic merge from submit-queue (batch tested with PRs 60632, 60806, 59471, 61251, 61013). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove method NewCronJobControllerFromClient **What this PR does / why we need it**: This method was originally introduced when cronjob was still called scheduledjob: https://github.com/kubernetes/kubernetes/commit/7a34347f7f7503dea787c6cb0f27c5e97b1c49d2 Back then, both init methods had different signatures. Since the rename to cronjob (https://github.com/kubernetes/kubernetes/commit/41d88d30ddbec0f06bc82bf087a85dfcc030db79), this method is an alias to the normal initializer, have the same signature and is not used anywhere in the codebase. Since this method was never actually used for cronjobs, it doesn't seem removing it would need any deprecation notice. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note Remove never used NewCronJobControllerFromClient method ```
parents 32858f98 6bd0a7d6
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 8 deletions
pkg/controller/cronjob/cronjob_controller.go
View file @ 60836d0d
...@@ -89,14 +89,6 @@ func NewCronJobController(kubeClient clientset.Interface) (*CronJobController, e ...@@ -89,14 +89,6 @@ func NewCronJobController(kubeClient clientset.Interface) (*CronJobController, e
return jm, nil return jm, nil
} }
func NewCronJobControllerFromClient(kubeClient clientset.Interface) (*CronJobController, error) {
jm, err := NewCronJobController(kubeClient)
if err != nil {
return nil, err
}
return jm, nil
}
// Run the main goroutine responsible for watching and syncing jobs. // Run the main goroutine responsible for watching and syncing jobs.
func (jm *CronJobController) Run(stopCh <-chan struct{}) { func (jm *CronJobController) Run(stopCh <-chan struct{}) {
defer utilruntime.HandleCrash() defer utilruntime.HandleCrash()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment